Reenable controller tests and drop focus#2650
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
==========================================
+ Coverage 38.26% 38.43% +0.16%
==========================================
Files 305 305
Lines 26271 26276 +5
==========================================
+ Hits 10053 10098 +45
+ Misses 15459 15425 -34
+ Partials 759 753 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| // Try to get GVK from the listed object first (works in production) | ||
| gvk := objAPIServer.GetObjectKind().GroupVersionKind() | ||
|
|
||
| // If GVK is empty (e.g., in fake client tests), get it from the scheme |
There was a problem hiding this comment.
Nice! It's a test-only code path, so should be fine, but if we have different versions for a given object e.g. v1alpha1 and v2alpha1, we have no guarantee on it. Shouldn't matter once again for a test path and I don't see a clean way to guarantee the version as we can't know in advance.
There was a problem hiding this comment.
that's a good point but yes, it's expected to affect only test fallbacks cases (single test case now) since current setup works fine in real clusters.
What does this PR do?
Drop the focus feature to reenable all tests. Tests fail with
d9eca94 resolves the issue.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel