Levan m/dependabot/go modules/k8s.io/apimachinery 0.35.0#2681
Conversation
- Upgrade k8s.io/api, apiextensions-apiserver, apiserver, client-go, component-base to v0.35.1 - Upgrade sigs.k8s.io/karpenter to v1.9.0 - Upgrade sigs.k8s.io/controller-runtime to v0.22.4 - Fix Karpenter API breaking change in NodeSelectorRequirementWithMinValues (no longer embeds NodeSelectorRequirement, use flat fields instead) - Update test/e2e go.mod/go.sum via go mod tidy - Regenerate CRDs and documentation
6e0dbc2 to
12f95e6
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dependabot/go_modules/k8s.io/apimachinery-0.35.0 #2681 +/- ##
===================================================================================
Coverage ? 38.73%
===================================================================================
Files ? 307
Lines ? 26522
Branches ? 0
===================================================================================
Hits ? 10274
Misses ? 15483
Partials ? 765
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| `global.kubelet.host.fileKeyRef.key` | ||
| : The key within the env file. An invalid key will prevent the pod from starting. The keys defined within a source may consist of any printable ASCII characters except '='. During Alpha stage of the EnvFiles feature gate, the key size is limited to 128 characters. | ||
|
|
||
| `global.kubelet.host.fileKeyRef.optional` | ||
| : Specify whether the file or its key must be defined. If the file or key does not exist, then the env var is not published. If optional is set to true and the specified key does not exist, the environment variable will not be set in the Pod's containers. If optional is set to false and the specified key does not exist, an error will be returned during Pod creation. | ||
|
|
||
| `global.kubelet.host.fileKeyRef.path` | ||
| : The path within the volume from which to select the file. Must be relative and may not contain the '..' path or start with '..'. | ||
|
|
||
| `global.kubelet.host.fileKeyRef.volumeName` | ||
| : The name of the volume mount containing the env file. | ||
|
|
There was a problem hiding this comment.
This is "ugly/useless", it's not really introduced by this PR since we have the same for resourceFieldRef and so on. I'll make a PR to add // +doc-gen:truncate to this field and some others:
edit: #2706
e007ad8
into
dependabot/go_modules/k8s.io/apimachinery-0.35.0
* Bump k8s.io/apimachinery from 0.33.3 to 0.35.0 Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.33.3 to 0.35.0. - [Commits](kubernetes/apimachinery@v0.33.3...v0.35.0) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Levan m/dependabot/go modules/k8s.io/apimachinery 0.35.0 (#2681) * Upgrade k8s.io dependencies to v0.35.1 and fix Karpenter API - Upgrade k8s.io/api, apiextensions-apiserver, apiserver, client-go, component-base to v0.35.1 - Upgrade sigs.k8s.io/karpenter to v1.9.0 - Upgrade sigs.k8s.io/controller-runtime to v0.22.4 - Fix Karpenter API breaking change in NodeSelectorRequirementWithMinValues (no longer embeds NodeSelectorRequirement, use flat fields instead) - Update test/e2e go.mod/go.sum via go mod tidy - Regenerate CRDs and documentation * Fixes * mod tidy e2e; go work sync after update-golang * update licenses * Fix `unstructured object has no kind` in store.go * another fake client update * Remove `go mod tidy` added to e2e golangci-lint run * go.work.sum --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com> Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com>
What does this PR do?
A brief description of the change being made with this pull request.
Failing due to this change kubernetes-sigs/controller-runtime#3229, related issue kubernetes-sigs/controller-runtime#3302.
Small functional changes
29cd7b5 run
go mod tidybeforegolangci-lintfor e2e, removed in last commit. Also movego work syncto the end ofupdate-golang.shscript as it adds different patch versions togodirective in go.mod files, likely due to min version requirement for respective dependency tree.eac776f store.go change to accomodate fake client, similar to change in #2650.
098eb84 test change not to reuse clientBuilder, broke with dependency bump.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel