Skip to content

Levan m/dependabot/go modules/k8s.io/apimachinery 0.35.0#2681

Merged
levan-m merged 7 commits intodependabot/go_modules/k8s.io/apimachinery-0.35.0from
levan-m/dependabot/go_modules/k8s.io/apimachinery-0.35.0
Mar 6, 2026
Merged

Levan m/dependabot/go modules/k8s.io/apimachinery 0.35.0#2681
levan-m merged 7 commits intodependabot/go_modules/k8s.io/apimachinery-0.35.0from
levan-m/dependabot/go_modules/k8s.io/apimachinery-0.35.0

Conversation

@levan-m
Copy link
Copy Markdown
Collaborator

@levan-m levan-m commented Mar 2, 2026

What does this PR do?

A brief description of the change being made with this pull request.

Failing due to this change kubernetes-sigs/controller-runtime#3229, related issue kubernetes-sigs/controller-runtime#3302.

Small functional changes
29cd7b5 run go mod tidy before golangci-lint for e2e, removed in last commit. Also move go work sync to the end of update-golang.sh script as it adds different patch versions to go directive in go.mod files, likely due to min version requirement for respective dependency tree.
eac776f store.go change to accomodate fake client, similar to change in #2650.
098eb84 test change not to reuse clientBuilder, broke with dependency bump.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

- Upgrade k8s.io/api, apiextensions-apiserver, apiserver, client-go, component-base to v0.35.1
- Upgrade sigs.k8s.io/karpenter to v1.9.0
- Upgrade sigs.k8s.io/controller-runtime to v0.22.4
- Fix Karpenter API breaking change in NodeSelectorRequirementWithMinValues
  (no longer embeds NodeSelectorRequirement, use flat fields instead)
- Update test/e2e go.mod/go.sum via go mod tidy
- Regenerate CRDs and documentation
@levan-m levan-m added dependencies Pull requests that update a dependency file qa/skip-qa labels Mar 2, 2026
@levan-m levan-m force-pushed the levan-m/dependabot/go_modules/k8s.io/apimachinery-0.35.0 branch from 6e0dbc2 to 12f95e6 Compare March 2, 2026 23:13
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dependabot/go_modules/k8s.io/apimachinery-0.35.0@694b73f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...atadog/autoscaling/cluster/install/k8s/nodepool.go 0.00% 12 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                                 Coverage Diff                                 @@
##             dependabot/go_modules/k8s.io/apimachinery-0.35.0    #2681   +/-   ##
===================================================================================
  Coverage                                                    ?   38.73%           
===================================================================================
  Files                                                       ?      307           
  Lines                                                       ?    26522           
  Branches                                                    ?        0           
===================================================================================
  Hits                                                        ?    10274           
  Misses                                                      ?    15483           
  Partials                                                    ?      765           
Flag Coverage Δ
unittests 38.73% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/datadogagent/store/store.go 68.39% <100.00%> (ø)
...atadog/autoscaling/cluster/install/k8s/nodepool.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694b73f...39bfde7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@levan-m levan-m marked this pull request as ready for review March 5, 2026 22:19
@levan-m levan-m requested review from a team as code owners March 5, 2026 22:19
Comment on lines +495 to +506
`global.kubelet.host.fileKeyRef.key`
: The key within the env file. An invalid key will prevent the pod from starting. The keys defined within a source may consist of any printable ASCII characters except '='. During Alpha stage of the EnvFiles feature gate, the key size is limited to 128 characters.

`global.kubelet.host.fileKeyRef.optional`
: Specify whether the file or its key must be defined. If the file or key does not exist, then the env var is not published. If optional is set to true and the specified key does not exist, the environment variable will not be set in the Pod's containers. If optional is set to false and the specified key does not exist, an error will be returned during Pod creation.

`global.kubelet.host.fileKeyRef.path`
: The path within the volume from which to select the file. Must be relative and may not contain the '..' path or start with '..'.

`global.kubelet.host.fileKeyRef.volumeName`
: The name of the volume mount containing the env file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is "ugly/useless", it's not really introduced by this PR since we have the same for resourceFieldRef and so on. I'll make a PR to add // +doc-gen:truncate to this field and some others:
edit: #2706

@levan-m levan-m merged commit e007ad8 into dependabot/go_modules/k8s.io/apimachinery-0.35.0 Mar 6, 2026
32 checks passed
@levan-m levan-m deleted the levan-m/dependabot/go_modules/k8s.io/apimachinery-0.35.0 branch March 6, 2026 14:44
levan-m added a commit that referenced this pull request Mar 9, 2026
* Bump k8s.io/apimachinery from 0.33.3 to 0.35.0

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.33.3 to 0.35.0.
- [Commits](kubernetes/apimachinery@v0.33.3...v0.35.0)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.35.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Levan m/dependabot/go modules/k8s.io/apimachinery 0.35.0 (#2681)

* Upgrade k8s.io dependencies to v0.35.1 and fix Karpenter API

- Upgrade k8s.io/api, apiextensions-apiserver, apiserver, client-go, component-base to v0.35.1
- Upgrade sigs.k8s.io/karpenter to v1.9.0
- Upgrade sigs.k8s.io/controller-runtime to v0.22.4
- Fix Karpenter API breaking change in NodeSelectorRequirementWithMinValues
  (no longer embeds NodeSelectorRequirement, use flat fields instead)
- Update test/e2e go.mod/go.sum via go mod tidy
- Regenerate CRDs and documentation

* Fixes

* mod tidy e2e; go work sync after update-golang

* update licenses

* Fix `unstructured object has no kind` in store.go

* another fake client update

* Remove `go mod tidy` added to e2e golangci-lint run

* go.work.sum

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file qa/skip-qa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants