Add initial DynamicConfig API and use it to maintain service mappings#5103
Merged
Add initial DynamicConfig API and use it to maintain service mappings#5103
Conversation
mcculls
added
tag: do not merge
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
mcculls
force-pushed
the
mcculls/dynamic-config-api
branch
4 times, most recently
from
001f01f to
3a7058f
Compare
mcculls
force-pushed
the
mcculls/dynamic-config-api
branch
from
3a7058f to
e38e5f2
Compare
mcculls
changed the title
Contributor
|
It starts having more and more code duplicate. I wonder if there could be a way to have a module to share some helpers for 3.x version for example (if it ever makes sense) |
Contributor
Author
what duplication - was this comment meant for a different PR? |
Contributor
It was... Probably an issue with VS code pull request plugin 🤷 Sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Initial API for dynamic configuration which supports capturing a snapshot for the duration of a trace.
More elements will be added to
TraceConfigas selected static config elements are made dynamic.