parametric: add dynamic config tests#1172
Conversation
robertomonteromiguel
left a comment
robertomonteromiguel
left a comment
There was a problem hiding this comment.
We are migrating step by step the parametric tests as a system-tests scenario.
Please let me know when you are ready to merge this PR, in order to merge to the new parametric folder.
Take a look: https://github.com/DataDog/system-tests/tree/main/tests/parametric
this is done in #1442 now
pawelchcki
left a comment
pawelchcki
left a comment
There was a problem hiding this comment.
Looks good to me.
I would be interested to see if the RC tests are not more flaky - overall, and the runtime is not extended too much.
But as is it looks ok to me. (other than one small nit question)
cbeauchesne
left a comment
cbeauchesne
left a comment
There was a problem hiding this comment.
The CI is failing : https://github.com/DataDog/system-tests/actions/runs/5755478486/job/15603094324?pr=1172
But I don't know if it's related. If it's not, AGTM
| 1) Validate the sample rate is effective (approx sample_rate% of traces should be received) | ||
| 2) The `_dd.rule_psr` metric is set to the correct value. | ||
| """ | ||
| # This tag should be set on the first span in a chunk (first span in the list of spans sent to the agent). |
There was a problem hiding this comment.
Tag _dd.rule_psr is added to the root span, which is not guaranteed to be the first span in a payload (the span order is not defined).
9 participants
Description
Add shared tests for the first version of Dynamic Configuration of trace libraries (via Remote Config). Dynamic Configuration is the ability for the APM libraries to reconfigure themselves at runtime in response to configuration received via Remote Configuration.
V1 of Dynamic Config (targeted for public beta) includes three options which can be configured:
Tests for these options are added here.
In order to support testing the header tagging, new RPCs are added to the interface to enable requests to be made with an HTTP client and to an HTTP web server.
Depends on:
Additional notes