Skip to content

add support for remote tracing configuration#3395

Merged
rochdev merged 10 commits intomasterfrom
tracing-remote-config
Jul 31, 2023
Merged

add support for remote tracing configuration#3395
rochdev merged 10 commits intomasterfrom
tracing-remote-config

Conversation

@rochdev
Copy link
Copy Markdown
Member

@rochdev rochdev commented Jul 14, 2023

What does this PR do?

Add support for remote tracing configuration. I also added some basic change detection so that changes can be reported to telemetry.

Motivation

This is needed to be able to configure some of the tracing options from the UI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 14, 2023

Overall package size

Self size: 4.99 MB
Deduped: 58.75 MB
No deduping: 58.84 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.1 40.97 kB 704.35 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2023

Codecov Report

Merging #3395 (87b8ef5) into master (5562378) will decrease coverage by 0.19%.
Report is 2 commits behind head on master.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #3395      +/-   ##
==========================================
- Coverage   84.42%   84.24%   -0.19%     
==========================================
  Files         218      216       -2     
  Lines        8636     8543      -93     
  Branches       33       33              
==========================================
- Hits         7291     7197      -94     
- Misses       1345     1346       +1     
Files Changed Coverage Δ
packages/dd-trace/src/noop/tracer.js 66.66% <ø> (ø)
packages/dd-trace/src/telemetry/index.js 88.88% <44.44%> (-6.43%) ⬇️
packages/dd-trace/src/proxy.js 90.90% <90.00%> (-0.76%) ⬇️
packages/dd-trace/src/config.js 97.19% <90.32%> (-1.93%) ⬇️
...ackages/dd-trace/src/appsec/remote_config/index.js 100.00% <100.00%> (ø)
...kages/dd-trace/src/appsec/remote_config/manager.js 100.00% <100.00%> (ø)
packages/dd-trace/src/plugin_manager.js 98.57% <100.00%> (+0.02%) ⬆️
packages/dd-trace/src/plugins/util/web.js 90.73% <100.00%> (+0.07%) ⬆️
packages/dd-trace/src/priority_sampler.js 100.00% <100.00%> (ø)
packages/dd-trace/src/startup-log.js 98.24% <100.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jul 14, 2023

Benchmarks

Benchmark execution time: 2023-07-29 17:12:37

Comparing candidate commit 87b8ef5 in PR branch tracing-remote-config with baseline commit 5562378 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 473 metrics, 19 unstable metrics.

@rochdev rochdev force-pushed the tracing-remote-config branch from 02efe05 to b8c7a78 Compare July 17, 2023 02:21
@rochdev rochdev marked this pull request as ready for review July 19, 2023 02:24
@rochdev rochdev requested review from a team as code owners July 19, 2023 02:24
Comment thread packages/dd-trace/src/appsec/remote_config/manager.js
Qard
Qard previously approved these changes Jul 20, 2023
Copy link
Copy Markdown
Contributor

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be nice if we didn't have to do all that splitting repeatedly, it'd be better if we can do that only when the config changes. 🤔

Comment thread packages/datadog-plugin-http/src/client.js Outdated
Qard
Qard previously approved these changes Jul 21, 2023
Qard
Qard previously approved these changes Jul 21, 2023
@rochdev rochdev merged commit 80bfef4 into master Jul 31, 2023
@rochdev rochdev deleted the tracing-remote-config branch July 31, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants