add support for remote tracing configuration#3395
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.99 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3395 +/- ##
==========================================
- Coverage 84.42% 84.24% -0.19%
==========================================
Files 218 216 -2
Lines 8636 8543 -93
Branches 33 33
==========================================
- Hits 7291 7197 -94
- Misses 1345 1346 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
02efe05 to
b8c7a78
Compare
simon-id
reviewed
Jul 19, 2023
Qard
previously approved these changes
Jul 20, 2023
Contributor
Qard
left a comment
There was a problem hiding this comment.
LGTM, but it would be nice if we didn't have to do all that splitting repeatedly, it'd be better if we can do that only when the config changes. 🤔
Qard
previously approved these changes
Jul 21, 2023
Qard
previously approved these changes
Jul 21, 2023
ida613
approved these changes
Jul 31, 2023
simon-id
approved these changes
Jul 31, 2023
rochdev
added a commit
that referenced
this pull request
Jul 31, 2023
rochdev
added a commit
that referenced
this pull request
Jul 31, 2023
rochdev
added a commit
that referenced
this pull request
Jul 31, 2023
rochdev
added a commit
that referenced
this pull request
Jul 31, 2023
rochdev
added a commit
that referenced
this pull request
Jul 31, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for remote tracing configuration. I also added some basic change detection so that changes can be reported to telemetry.
Motivation
This is needed to be able to configure some of the tracing options from the UI.