Conversation
- specifically looking for exactly node 21 - this way we will have to fix it when node 22 LTS is released --------- Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
Co-authored-by: Martin Disch <martindisch@gmail.com>
* default error tagging for next and pageLoad safeguarding
#3889) * Configure parametric test to get the nodejs tracer in same way as system-tests
* Upload module skeleton. * Blocking in apollo, very very first version * Move graphql implementation to another module. * Blocking for apollo-server-core, ugly but it works, lets find a better way * Use real blocking data * Set blocking to true. * Throw before resolver execution in order to stop the operation's execution flow. * Use HttpQueryError in apollo-server-core * Blocking test in apollo-server-fastify * Refactor graphql blocking. * Remove previous implementation which only supported monitoring. * Add new waf address in order to check the payload of every resolver. * Use apm start resolver address instead of a new one. * Remove mock and perform an actual call to the waf. * Add non blocking graphql test * Move abortController constructor to context creation. This reduces the performance overhead due to just one instance is shared across the whole query exectution. * Add pollo-server-express block tests * Add unit tests. * Add @apollo/server tests * Update test rules for blocking by `graphql.server.resolver` * Block with graphql templates data * Add tests. * Block with graphql data in graphql endpoint * Fix tests. * Execute @apollo/server and apollo-server-express tests * Unify code in @apollo/server and apollo-server-core * update comments * Add appsec.blocked tag in blocked requests * Add test with non graphql block response * Tests for block with redirect * Prevent creation of resolve span when it is blocked before the execution of the resolve code * Refactor addResolver in order to get directives information. * Add tests to block on directives. * Add test for directives. * Undo prevent creating resolve span * Configurable graphql blocking json * Refactor graphql * Using resolver instead of resolvers. * Change graphql channel name to be consistent with the others. * Small changes in blocking * Move resover information resolution to plugin. * Revert "Move resover information resolution to plugin." This reverts commit 7cc8561. * Remove resolver information from context, pass it in a different field instead. * Throw custom exception rather than send an empty array. * Update packages/datadog-instrumentations/src/graphql.js Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> * Change a bit apollo-server-core instrumentation * Protect Header map, if in future version it is moved/removed, prevent breaks * Remove some duplicated code * Update packages/datadog-instrumentations/src/apollo-server.js Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com> * Fix comments in the PR * Fix PR comments. * Fix some comments in the PR * Move resolver information formatting to the plugin. * Fix PR comments. * Fix proper use of Promise.race. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: Carles Capell <107924659+CarlesDD@users.noreply.github.com>
* Add thread id to heap and wall profiles * Allow generateLabels to be called without arguments In wall profile, if generateLabels is called without arguments, return thread labels.
* New RC ASM_API_SECURITY_SAMPLE_RATE capability * Do not report ASM_API_SECURITY_SAMPLE_RATE capability if apiSecurity is not enabled * Change Activation constants case * Update ASM_API_SECURITY_SAMPLE_RATE capability when enabling RemoteConfig * Apply same coertion logic as in config.js * Clean up * Do not turn off ASM_API_SECURITY_SAMPLE_RATE when disabling waf update * Include api_security_sampler test case * Fix test comment * remove NOTE
* Ensure recording start time of next profile is the same as the recording end time of the current profile. * Pass the start-end range to profilers so they can use it * Use passed-in start-end instead of internal duration computations * Use end date to cut off late events for the next profile
* github: suggest new issues use helpdesk instead * remove deprecated bug report / feature request options
* Update waf bindings to 6.0.0. * Pass graphql.server.resolver as ephemeral address type. * Add test.
Contributor
Overall package sizeSelf size: 5.78 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.x #3899 +/- ##
=======================================
Coverage ? 84.74%
=======================================
Files ? 237
Lines ? 9944
Branches ? 33
=======================================
Hits ? 8427
Misses ? 1517
Partials ? 0 ☔ View full report in Codecov by Sentry. |
juan-fernandez
approved these changes
Dec 21, 2023
Collaborator
juan-fernandez
left a comment
juan-fernandez
left a comment
There was a problem hiding this comment.
looks from ci vis perspective. A nitpick:
civisibility: ignore pino error tests when node version is 21 (Fix pino tests #3878)
that's not a ci vis fix 😄 . I'd just put pino
Qard
approved these changes
Dec 21, 2023
iunanua
approved these changes
Dec 21, 2023
szegedi
approved these changes
Dec 21, 2023
Contributor
szegedi
left a comment
szegedi
left a comment
There was a problem hiding this comment.
Ok from profiling - thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Improvements
Features
Will be omitted from Release Notes: