Skip to content

Pass resolver address as ephemeral type#3897

Merged
hoolioh merged 3 commits intomasterfrom
julio/ephemeral-graphql
Dec 21, 2023
Merged

Pass resolver address as ephemeral type#3897
hoolioh merged 3 commits intomasterfrom
julio/ephemeral-graphql

Conversation

@hoolioh
Copy link
Copy Markdown
Contributor

@hoolioh hoolioh commented Dec 20, 2023

What does this PR do?

Since graphql.server.resolver is a recurrent address which is sent multiple times during a request it needs to be passed as a ephemeral type in order to get API Security info from it.
This PR also updates waf bindings module to version 6.0.0 in order to make ephemeral addresses to work.

  • Unit tests.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 20, 2023

Overall package size

Self size: 5.79 MB
Deduped: 61.2 MB
No deduping: 61.96 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 6.0.0 14.48 MB 14.48 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bf0565) 84.59% compared to head (fbb0389) 84.59%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3897   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         235      235           
  Lines        9760     9769    +9     
  Branches       33       33           
=======================================
+ Hits         8256     8264    +8     
- Misses       1504     1505    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoolioh hoolioh marked this pull request as ready for review December 20, 2023 16:09
@hoolioh hoolioh requested review from a team as code owners December 20, 2023 16:09
Qard
Qard previously approved these changes Dec 20, 2023
Comment thread packages/dd-trace/src/appsec/waf/waf_context_wrapper.js
Comment thread packages/dd-trace/src/appsec/waf/waf_context_wrapper.js Outdated
@hoolioh hoolioh merged commit 1c5e578 into master Dec 21, 2023
@hoolioh hoolioh deleted the julio/ephemeral-graphql branch December 21, 2023 10:12
hoolioh added a commit that referenced this pull request Dec 21, 2023
* Update waf bindings to 6.0.0.

* Pass graphql.server.resolver as ephemeral address type.

* Add test.
@hoolioh hoolioh mentioned this pull request Dec 21, 2023
hoolioh added a commit that referenced this pull request Dec 21, 2023
* Update waf bindings to 6.0.0.

* Pass graphql.server.resolver as ephemeral address type.

* Add test.
@hoolioh hoolioh mentioned this pull request Dec 21, 2023
CarlesDD pushed a commit that referenced this pull request Dec 21, 2023
* Update waf bindings to 6.0.0.

* Pass graphql.server.resolver as ephemeral address type.

* Add test.
CarlesDD pushed a commit that referenced this pull request Dec 21, 2023
* Update waf bindings to 6.0.0.

* Pass graphql.server.resolver as ephemeral address type.

* Add test.
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
* Update waf bindings to 6.0.0.

* Pass graphql.server.resolver as ephemeral address type.

* Add test.
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
* Update waf bindings to 6.0.0.

* Pass graphql.server.resolver as ephemeral address type.

* Add test.
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
* Update waf bindings to 6.0.0.

* Pass graphql.server.resolver as ephemeral address type.

* Add test.
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
* Update waf bindings to 6.0.0.

* Pass graphql.server.resolver as ephemeral address type.

* Add test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants