Conversation
Contributor
Overall package sizeSelf size: 5.66 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3853 +/- ##
==========================================
+ Coverage 84.95% 87.61% +2.65%
==========================================
Files 233 227 -6
Lines 9637 9017 -620
Branches 33 33
==========================================
- Hits 8187 7900 -287
+ Misses 1450 1117 -333 ☔ View full report in Codecov by Sentry. |
khanayan123
approved these changes
Dec 8, 2023
rochdev
approved these changes
Dec 8, 2023
Member
rochdev
left a comment
There was a problem hiding this comment.
It would be safer to use shimmer to do the patching, but this method is extremely unlikely to change to it should be fine.
khanayan123
pushed a commit
that referenced
this pull request
Dec 12, 2023
…corded as Errors When Using Node 20 (#3853) * req.socket timeouts recorded as errors node 20 * check for process.send
khanayan123
pushed a commit
that referenced
this pull request
Dec 13, 2023
…corded as Errors When Using Node 20 (#3853) * req.socket timeouts recorded as errors node 20 * check for process.send
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
…corded as Errors When Using Node 20 (#3853) * req.socket timeouts recorded as errors node 20 * check for process.send
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
…corded as Errors When Using Node 20 (#3853) * req.socket timeouts recorded as errors node 20 * check for process.send
Merged
Merged
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
…corded as Errors When Using Node 20 (#3853) * req.socket timeouts recorded as errors node 20 * check for process.send
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
…corded as Errors When Using Node 20 (#3853) * req.socket timeouts recorded as errors node 20 * check for process.send
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
…corded as Errors When Using Node 20 (#3853) * req.socket timeouts recorded as errors node 20 * check for process.send
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
…corded as Errors When Using Node 20 (#3853) * req.socket timeouts recorded as errors node 20 * check for process.send
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes sure intentional
setTimeoutcalls on the underlying socket for a request are captured for recording errors on timeouts when using Node 20. See the linked PR below, but because Node 20 defaults to 5s timeouts on the global agent, we want to ignore those timeouts as errors, but record intentional ones as errors.Motivation
Addresses concern after merging #3841
Security
Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!