Skip to content

Revert "enable tracing header injection for AWS requests (#3796)"#3799

Merged
tlhunter merged 1 commit intomasterfrom
tlhunter/revert-aws-header
Nov 15, 2023
Merged

Revert "enable tracing header injection for AWS requests (#3796)"#3799
tlhunter merged 1 commit intomasterfrom
tlhunter/revert-aws-header

Conversation

@tlhunter
Copy link
Copy Markdown
Member

What does this PR do?

Motivation

@tlhunter tlhunter requested review from a team as code owners November 15, 2023 19:37
@tlhunter tlhunter requested a review from jbertran November 15, 2023 19:37
@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 5.56 MB
Deduped: 61.21 MB
No deduping: 61.97 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 4.0.0 14.83 MB 14.83 MB
@datadog/pprof 4.0.1 9.32 MB 10.16 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.2.1 2.27 MB 2.36 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a1ce1d) 84.01% compared to head (9b08c87) 85.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3799      +/-   ##
==========================================
+ Coverage   84.01%   85.10%   +1.09%     
==========================================
  Files         228      228              
  Lines        9308     9308              
  Branches       33       33              
==========================================
+ Hits         7820     7922     +102     
+ Misses       1488     1386     -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 15, 2023

Benchmarks

Benchmark execution time: 2023-11-15 19:43:22

Comparing candidate commit 9b08c87 in PR branch tlhunter/revert-aws-header with baseline commit 7a1ce1d in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 519 metrics, 12 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-135.093MB; -109.099MB] or [-14.004%; -11.309%]

@tlhunter tlhunter merged commit 7abbcc5 into master Nov 15, 2023
@tlhunter tlhunter deleted the tlhunter/revert-aws-header branch November 15, 2023 20:51
tlhunter added a commit that referenced this pull request Nov 15, 2023
)

- reverts PR #3796
- reverts commit 14c1eb0
- @rochdev and @astuyve are both confident this is a breaking change
tlhunter added a commit that referenced this pull request Nov 15, 2023
)

- reverts PR #3796
- reverts commit 14c1eb0
- @rochdev and @astuyve are both confident this is a breaking change
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
)

- reverts PR #3796
- reverts commit 14c1eb0
- @rochdev and @astuyve are both confident this is a breaking change
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
)

- reverts PR #3796
- reverts commit 14c1eb0
- @rochdev and @astuyve are both confident this is a breaking change
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
)

- reverts PR #3796
- reverts commit 14c1eb0
- @rochdev and @astuyve are both confident this is a breaking change
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
)

- reverts PR #3796
- reverts commit 14c1eb0
- @rochdev and @astuyve are both confident this is a breaking change
erikvanbrakel pushed a commit to mazedesignhq/dd-trace-js that referenced this pull request Jul 5, 2024
…" (DataDog#3799)

- reverts PR DataDog#3796
- reverts commit 14c1eb0
- @rochdev and @astuyve are both confident this is a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants