configurable tracing header w/ aws signed request#3836
Merged
Conversation
Contributor
Overall package sizeSelf size: 5.61 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3836 +/- ##
==========================================
- Coverage 85.21% 84.87% -0.35%
==========================================
Files 230 230
Lines 9546 9587 +41
Branches 33 33
==========================================
+ Hits 8135 8137 +2
- Misses 1411 1450 +39 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2023-12-01 19:31:01 Comparing candidate commit f59c866 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 519 metrics, 12 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
tlhunter
force-pushed
the
tlhunter/trace-aws
branch
from
5f2bf75 to
ced812e
Compare
rochdev
reviewed
Nov 30, 2023
| client: httpClientOptions | ||
| }); | ||
| tracer.use('http', { | ||
| enableTracingWithAmazonSignature: true |
Member
There was a problem hiding this comment.
Tracing is always enabled, it's only propagation that changes.
tlhunter
force-pushed
the
tlhunter/trace-aws
branch
from
76512b2 to
0bcfdbf
Compare
sabrenner
previously approved these changes
Dec 1, 2023
tlhunter
force-pushed
the
tlhunter/trace-aws
branch
from
0bcfdbf to
f59c866
Compare
sabrenner
approved these changes
Dec 1, 2023
khanayan123
pushed a commit
that referenced
this pull request
Dec 12, 2023
- adds a new `http` service configuration option `enablePropagationWithAmazonHeaders` - defaults to `false` which is current behavior - when set to `true` it will allow injecting tracing headers for requests signed via AWS IAM headers - allows customer applications which communicate across services with signed requests to be traced - making this a configurable since there may be use-cases which the change could break
khanayan123
pushed a commit
that referenced
this pull request
Dec 13, 2023
- adds a new `http` service configuration option `enablePropagationWithAmazonHeaders` - defaults to `false` which is current behavior - when set to `true` it will allow injecting tracing headers for requests signed via AWS IAM headers - allows customer applications which communicate across services with signed requests to be traced - making this a configurable since there may be use-cases which the change could break
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
- adds a new `http` service configuration option `enablePropagationWithAmazonHeaders` - defaults to `false` which is current behavior - when set to `true` it will allow injecting tracing headers for requests signed via AWS IAM headers - allows customer applications which communicate across services with signed requests to be traced - making this a configurable since there may be use-cases which the change could break
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
- adds a new `http` service configuration option `enablePropagationWithAmazonHeaders` - defaults to `false` which is current behavior - when set to `true` it will allow injecting tracing headers for requests signed via AWS IAM headers - allows customer applications which communicate across services with signed requests to be traced - making this a configurable since there may be use-cases which the change could break
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
- adds a new `http` service configuration option `enablePropagationWithAmazonHeaders` - defaults to `false` which is current behavior - when set to `true` it will allow injecting tracing headers for requests signed via AWS IAM headers - allows customer applications which communicate across services with signed requests to be traced - making this a configurable since there may be use-cases which the change could break
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
- adds a new `http` service configuration option `enablePropagationWithAmazonHeaders` - defaults to `false` which is current behavior - when set to `true` it will allow injecting tracing headers for requests signed via AWS IAM headers - allows customer applications which communicate across services with signed requests to be traced - making this a configurable since there may be use-cases which the change could break
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
- adds a new `http` service configuration option `enablePropagationWithAmazonHeaders` - defaults to `false` which is current behavior - when set to `true` it will allow injecting tracing headers for requests signed via AWS IAM headers - allows customer applications which communicate across services with signed requests to be traced - making this a configurable since there may be use-cases which the change could break
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
- adds a new `http` service configuration option `enablePropagationWithAmazonHeaders` - defaults to `false` which is current behavior - when set to `true` it will allow injecting tracing headers for requests signed via AWS IAM headers - allows customer applications which communicate across services with signed requests to be traced - making this a configurable since there may be use-cases which the change could break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
httpservice configuration optionenablePropagationWithAmazonHeadersfalsewhich is current behaviortrueit will allow injecting tracing headers for requests signed via AWS IAM headersMotivation
Plugin Checklist
Additional Notes
Security
Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!