Skip to content

PROF-10329, APMAPI-213: Make sure profiling.enabled is boolean for telemetry#4613

Merged
szegedi merged 2 commits intomasterfrom
szegedi/fix-telemetry-profiling-enabled
Aug 19, 2024
Merged

PROF-10329, APMAPI-213: Make sure profiling.enabled is boolean for telemetry#4613
szegedi merged 2 commits intomasterfrom
szegedi/fix-telemetry-profiling-enabled

Conversation

@szegedi
Copy link
Copy Markdown
Contributor

@szegedi szegedi commented Aug 19, 2024

What does this PR do?

  • For purposes of emitting app-client-configuration-change events, ensures profiling.enabled is a boolean. 'auto' is mapped as true, while 'true' and 'false' are self-explanatory.
  • Improved the logic for dealing with exceptions in telemetry/index.js:updateConfig() to use a cascade of else-ifs for mutually exclusive items.

Motivation

Telemetry schema expects profiling.enabled to be a boolean. #4592 broke that assumption.

@szegedi szegedi requested a review from a team as a code owner August 19, 2024 15:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 19, 2024

Overall package size

Self size: 6.98 MB
Deduped: 58.2 MB
No deduping: 58.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi force-pushed the szegedi/fix-telemetry-profiling-enabled branch from 64ff1cf to b576320 Compare August 19, 2024 15:22
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 19, 2024

Benchmarks

Benchmark execution time: 2024-08-19 15:33:55

Comparing candidate commit b576320 in PR branch szegedi/fix-telemetry-profiling-enabled with baseline commit 30af052 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@szegedi szegedi enabled auto-merge (squash) August 19, 2024 16:01
@szegedi szegedi merged commit c3b6258 into master Aug 19, 2024
@szegedi szegedi deleted the szegedi/fix-telemetry-profiling-enabled branch August 19, 2024 19:06
bengl pushed a commit that referenced this pull request Aug 29, 2024
bengl pushed a commit that referenced this pull request Aug 29, 2024
bengl pushed a commit that referenced this pull request Aug 30, 2024
bengl pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants