Skip to content

PROF-10329, APMAPI-213: Make sure products.profiler.enabled is boolean for telemetry#4615

Merged
szegedi merged 2 commits intomasterfrom
szegedi/fix-telemetry-2
Aug 20, 2024
Merged

PROF-10329, APMAPI-213: Make sure products.profiler.enabled is boolean for telemetry#4615
szegedi merged 2 commits intomasterfrom
szegedi/fix-telemetry-2

Conversation

@szegedi
Copy link
Copy Markdown
Contributor

@szegedi szegedi commented Aug 20, 2024

What does this PR do?

For purposes of emitting app-started telemetry events, ensures products.profiler.enabled is a boolean. 'auto' is mapped as true, while 'true' and 'false' are self-explanatory.

Motivation

Telemetry schema expects products.profiler.enabled in app-started to be a boolean. #4592 broke that assumption. Also, #4613 fixed a wrong thing, it ensured change record for profiling.enabled is a boolean in app-client-configuration-change events. This is the real fix.

@szegedi szegedi requested a review from a team as a code owner August 20, 2024 13:02
@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.98 MB
Deduped: 58.2 MB
No deduping: 58.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.91%. Comparing base (269b6c6) to head (6e2badf).
Report is 913 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/telemetry/index.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4615      +/-   ##
==========================================
+ Coverage   68.76%   68.91%   +0.14%     
==========================================
  Files         252      272      +20     
  Lines       11030    12014     +984     
  Branches       33       33              
==========================================
+ Hits         7585     8279     +694     
- Misses       3445     3735     +290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szegedi szegedi enabled auto-merge (squash) August 20, 2024 13:16
@szegedi szegedi merged commit 8a2b17b into master Aug 20, 2024
@szegedi szegedi deleted the szegedi/fix-telemetry-2 branch August 20, 2024 13:29
bengl pushed a commit that referenced this pull request Aug 29, 2024
bengl pushed a commit that referenced this pull request Aug 29, 2024
bengl pushed a commit that referenced this pull request Aug 30, 2024
bengl pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants