Skip to content

add support for cgroupv2 inode fallback#5508

Merged
rochdev merged 3 commits intomasterfrom
cgroupv2-inode
Apr 9, 2025
Merged

add support for cgroupv2 inode fallback#5508
rochdev merged 3 commits intomasterfrom
cgroupv2-inode

Conversation

@rochdev
Copy link
Copy Markdown
Member

@rochdev rochdev commented Mar 31, 2025

What does this PR do?

Add support for cgroupv2 inode fallback.

Motivation

When using cgroupv2 the container ID is not always set, but the inode can be used as a fallback for correlation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2025

Overall package size

Self size: 9.19 MB
Deduped: 101.72 MB
No deduping: 102.24 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.16%. Comparing base (b984e63) to head (089d30f).
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5508      +/-   ##
==========================================
- Coverage   79.24%   79.16%   -0.08%     
==========================================
  Files         512      512              
  Lines       23152    23171      +19     
==========================================
- Hits        18347    18344       -3     
- Misses       4805     4827      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Mar 31, 2025

Datadog Report

Branch report: cgroupv2-inode
Commit report: 55980d3
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 929 Passed, 0 Skipped, 15m 29.76s Total Time

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 1, 2025

Benchmarks

Benchmark execution time: 2025-04-01 18:57:35

Comparing candidate commit 089d30f in PR branch cgroupv2-inode with baseline commit b984e63 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 946 metrics, 17 unstable metrics.

@rochdev rochdev marked this pull request as ready for review April 1, 2025 19:01
@rochdev rochdev requested a review from a team as a code owner April 1, 2025 19:01
Comment thread packages/dd-trace/src/exporters/common/docker.js
@rochdev rochdev merged commit 7cabf67 into master Apr 9, 2025
427 checks passed
@rochdev rochdev deleted the cgroupv2-inode branch April 9, 2025 18:23
This was referenced Apr 10, 2025
github-actions Bot pushed a commit that referenced this pull request Apr 10, 2025
@github-actions github-actions Bot mentioned this pull request Apr 10, 2025
bengl pushed a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants