Conversation
* initial implementation * updating config test * fixing CI * update PR comments * updating test cases * updating config * fixing tests * addressing comments and cleanup
…es of different frameworks (#5550)
BenchmarksBenchmark execution time: 2025-04-10 23:02:52 Comparing candidate commit 666d358 in PR branch Found 0 performance improvements and 16 performance regressions! Performance is the same for 929 metrics, 18 unstable metrics. scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18
scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20
scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18
scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20
scenario:appsec-iast-startup-time-iast-enabled-18
scenario:appsec-iast-startup-time-iast-enabled-20
scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18
scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-20
scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18
scenario:plugin-bluebird-with-tracer-18
scenario:startup-with-tracer-18
scenario:startup-with-tracer-20
|
Co-authored-by: Sam Brenner <sam.brenner@datadoghq.com> Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
72f510e to
644216e
Compare
BridgeAR
left a comment
There was a problem hiding this comment.
RSLGTM
Should we just have a team that may generally create releases without an extra review?
644216e to
666d358
Compare
Overall package sizeSelf size: 9.28 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.0 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5.x #5571 +/- ##
=======================================
Coverage ? 79.32%
=======================================
Files ? 515
Lines ? 23369
Branches ? 0
=======================================
Hits ? 18538
Misses ? 4831
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 922 Passed, 0 Skipped, 19m 33.18s Total Time |
We could definitely do that. I think it's worth discussing trade-offs of the different approval strategies at the next guild meeting. In any case, the new workflow doesn't quite work right because of a limitation (I'd personally call it a significant bug) in GitHub Actions that has been going on for years. I'm working on a workaround but it will probably take a few days until it's ready so we can discuss this in the meantime while we continue to use the current release process. |
aea8aa5eb2] - (SEMVER-MINOR) new wasm rewriter w/ orchestrion (Bryan English) #549418b5a65ffa] - (SEMVER-PATCH) fix release proposal workflow commit permissions (Roch Devost) #55691533b16e3b] - (SEMVER-PATCH) fix proposal script not checking out new branch (Roch Devost) #5566593371edbe] - (SEMVER-PATCH) remove release proposal check for oauth scopes in ci (Roch Devost) #55649492745bd8] - (SEMVER-PATCH) update libdatadog to 0.5.1 and native-metrics to 3.1.1 (Roch Devost) #5563a59cfae14a] - (SEMVER-PATCH) Fix disable mongo hearbeats spans (Recreates Fix MongoDB heartbeat filtering when DD_TRACE_MONGODB_HEARTBEAT_ENABL… #5558) (simon-id) #55625fd669013e] - (SEMVER-PATCH) Constrain async ID collection to main thread only (Attila Szegedi) #5559a64340b1f2] - (SEMVER-PATCH) fix shimmer slow shim by removing support for unwrap (Roch Devost) #55571eefc0aa92] - (SEMVER-PATCH) Bump Appsec native packages (Carles Capell) #5561853152b338] - (SEMVER-PATCH) Update profiler from 5.7.0 to 5.7.1. (Attila Szegedi) #556038f62e9328] - (SEMVER-MINOR) [test-optimization] [SDTEST-1830] Add @test.retry_reason to the retries of different frameworks (Mario Vidal Domínguez) #55505ab3df29d1] - (SEMVER-PATCH) fix missing composite action in docs publish job (Roch Devost) #55567cabf67770] - (SEMVER-PATCH) add support for cgroupv2 inode fallback (Roch Devost) #5508a5095bedd1] - (SEMVER-PATCH) Filter out log infrastructure stack frames (Attila Szegedi) #551906cc8ac439] - (SEMVER-PATCH) Fix profiler test flakiness (Attila Szegedi) #55494686a4fe81] - (SEMVER-PATCH) remove application-config-path dependency (Roch Devost) #554728e8a593fa] - (SEMVER-MINOR) Adding Support forTRACE_PROPAGATION_BEHAVIOR_EXTRACT(mhlidd) #5525