Skip to content

fix proposal script not checking out new branch#5566

Merged
rochdev merged 1 commit intomasterfrom
release-proposal-test
Apr 10, 2025
Merged

fix proposal script not checking out new branch#5566
rochdev merged 1 commit intomasterfrom
release-proposal-test

Conversation

@rochdev
Copy link
Copy Markdown
Member

@rochdev rochdev commented Apr 10, 2025

What does this PR do?

Fix proposal script not checking out new branch.

Motivation

Sending the result of git checkout to /dev/null meant that the or condition would never run, thus never creating the proposal branch which led future steps to fail.

@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.28 MB
Deduped: 101.46 MB
No deduping: 101.98 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 3.1.0 | 2.37 MB | 2.52 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.23%. Comparing base (593371e) to head (7ba28b2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5566      +/-   ##
==========================================
- Coverage   79.29%   79.23%   -0.07%     
==========================================
  Files         513      512       -1     
  Lines       23291    23223      -68     
==========================================
- Hits        18468    18400      -68     
  Misses       4823     4823              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rochdev rochdev marked this pull request as ready for review April 10, 2025 17:54
@rochdev rochdev requested a review from a team as a code owner April 10, 2025 17:54
@rochdev rochdev enabled auto-merge (squash) April 10, 2025 17:57
@datadog-datadog-prod-us1
Copy link
Copy Markdown

Datadog Report

Branch report: release-proposal-test
Commit report: a1dc7a3
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 924 Passed, 0 Skipped, 10m 3.35s Total Time

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 10, 2025

Benchmarks

Benchmark execution time: 2025-04-10 18:01:25

Comparing candidate commit 7ba28b2 in PR branch release-proposal-test with baseline commit 593371e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 948 metrics, 15 unstable metrics.

@rochdev rochdev merged commit 1533b16 into master Apr 10, 2025
423 of 431 checks passed
@rochdev rochdev deleted the release-proposal-test branch April 10, 2025 18:03
This was referenced Apr 10, 2025
@github-actions github-actions Bot mentioned this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants