Adding Support for TRACE_PROPAGATION_BEHAVIOR_EXTRACT #5525
Conversation
Overall package sizeSelf size: 9.27 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.7.0 | 9.89 MB | 10.26 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 3.1.0 | 2.37 MB | 2.52 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5525 +/- ##
==========================================
- Coverage 79.25% 79.14% -0.11%
==========================================
Files 513 507 -6
Lines 23230 23067 -163
==========================================
- Hits 18411 18257 -154
+ Misses 4819 4810 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 926 Passed, 0 Skipped, 14m 10.85s Total Time |
BenchmarksBenchmark execution time: 2025-04-08 13:39:38 Comparing candidate commit 971f9bc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 946 metrics, 17 unstable metrics. |
khanayan123
left a comment
There was a problem hiding this comment.
Just some minor comments, mainly LGTM
* initial implementation * updating config test * fixing CI * update PR comments * updating test cases * updating config * fixing tests * addressing comments and cleanup
* initial implementation * updating config test * fixing CI * update PR comments * updating test cases * updating config * fixing tests * addressing comments and cleanup
* initial implementation * updating config test * fixing CI * update PR comments * updating test cases * updating config * fixing tests * addressing comments and cleanup
What does this PR do?
Introduces support for a new config
TRACE_PROPAGATION_BEHAVIOR_EXTRACT. RFCAccepted Values:
continue: The tracing library continues the trace from the incoming headers, if present. Also, incoming baggage is propagated. (Default Value)restart: The tracing library always starts a new trace with a new trace-id. Context extraction will occur as otherwise configured, except that the local span will no longer have a parent-child span relationship with the incoming trace context, instead it will reference the incoming trace context via a span link. Also, incoming baggage is propagated.ignore: The tracing library always starts a new trace with a new trace-id without creating any span links. Also, incoming baggage is dropped.Motivation
Plugin Checklist
Additional Notes