Skip to content

[NodeJS] Updating Manifests for Trace Context Propagation#4496

Merged
mhlidd merged 1 commit intomainfrom
mhlidd/enable_nodejs_tracecontext_propagation
Apr 8, 2025
Merged

[NodeJS] Updating Manifests for Trace Context Propagation#4496
mhlidd merged 1 commit intomainfrom
mhlidd/enable_nodejs_tracecontext_propagation

Conversation

@mhlidd
Copy link
Copy Markdown
Contributor

@mhlidd mhlidd commented Apr 8, 2025

Motivation

Following the changes made to introduce DD_TRACE_PROPAGATION_BEHAVIOR_EXTRACT, this PR enables the relevant system-tests that the above changes support.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd requested a review from a team as a code owner April 8, 2025 15:39
@mhlidd mhlidd merged commit 0c657d4 into main Apr 8, 2025
41 checks passed
@mhlidd mhlidd deleted the mhlidd/enable_nodejs_tracecontext_propagation branch April 8, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants