Skip to content

remove application-config-path dependency#5547

Merged
rochdev merged 1 commit intomasterfrom
remove-app-config-path
Apr 8, 2025
Merged

remove application-config-path dependency#5547
rochdev merged 1 commit intomasterfrom
remove-app-config-path

Conversation

@rochdev
Copy link
Copy Markdown
Member

@rochdev rochdev commented Apr 7, 2025

What does this PR do?

Remove application-config-path dependency.

Motivation

Having a dependency for the release proposal script makes it more difficult to automate quickly without pulling all dependencies, and also it turned out to be possible to replicate the same behaviour with 1 line of code per platform, so no need for an external dependency just for that.

@rochdev rochdev marked this pull request as ready for review April 7, 2025 20:15
@rochdev rochdev requested a review from a team as a code owner April 7, 2025 20:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2025

Overall package size

Self size: 9.24 MB
Deduped: 101.55 MB
No deduping: 102.07 MB

Dependency sizes
name version self size total size
@datadog/libdatadog 0.5.0 29.83 MB 29.83 MB
@datadog/native-appsec 8.5.1 19.26 MB 19.27 MB
@datadog/native-iast-taint-tracking 3.3.0 13.77 MB 13.78 MB
@datadog/pprof 5.6.0 9.79 MB 10.16 MB
@opentelemetry/core 1.30.1 908.66 kB 7.16 MB
protobufjs 7.4.0 2.77 MB 5.42 MB
@datadog/wasm-js-rewriter 3.1.0 2.37 MB 2.52 MB
@datadog/native-metrics 3.1.0 1.06 MB 1.46 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.13.1 117.64 kB 839.26 kB
source-map 0.7.4 226 kB 226 kB
opentracing 0.14.7 194.81 kB 194.81 kB
lru-cache 7.18.3 133.92 kB 133.92 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.1 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
ignore 5.3.2 53.63 kB 53.63 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
rfdc 1.4.1 27.15 kB 27.15 kB
@isaacs/ttlcache 1.4.1 25.2 kB 25.2 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
dc-polyfill 0.1.6 24.56 kB 24.56 kB
shell-quote 1.8.2 23.54 kB 23.54 kB
limiter 1.1.5 23.17 kB 23.17 kB
retry 0.13.1 18.85 kB 18.85 kB
semifies 1.0.0 15.84 kB 15.84 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
ttl-set 1.0.0 4.61 kB 9.69 kB
path-to-regexp 0.1.12 6.6 kB 6.6 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.26%. Comparing base (c9c351d) to head (60e390b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5547      +/-   ##
==========================================
- Coverage   79.32%   79.26%   -0.07%     
==========================================
  Files         513      512       -1     
  Lines       23264    23192      -72     
==========================================
- Hits        18455    18383      -72     
  Misses       4809     4809              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 7, 2025

Benchmarks

Benchmark execution time: 2025-04-07 20:21:47

Comparing candidate commit 60e390b in PR branch remove-app-config-path with baseline commit c9c351d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 944 metrics, 19 unstable metrics.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

Datadog Report

Branch report: remove-app-config-path
Commit report: c2cab07
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 925 Passed, 0 Skipped, 13m 42.23s Total Time

@rochdev rochdev merged commit 4686a4f into master Apr 8, 2025
428 checks passed
@rochdev rochdev deleted the remove-app-config-path branch April 8, 2025 15:29
This was referenced Apr 10, 2025
@github-actions github-actions Bot mentioned this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants