Skip to content

Fix disable mongo hearbeats spans (Recreates #5558)#5562

Merged
wconti27 merged 6 commits intomasterfrom
fix-disable-mongo-hearbeats-spans
Apr 10, 2025
Merged

Fix disable mongo hearbeats spans (Recreates #5558)#5562
wconti27 merged 6 commits intomasterfrom
fix-disable-mongo-hearbeats-spans

Conversation

@simon-id
Copy link
Copy Markdown
Member

@simon-id simon-id commented Apr 10, 2025

What does this PR do?

Recreates #5562.
Fix a bug in the mongodb plugin would not take the DD_TRACE_MONGODB_HEARTBEAT_ENABLED env var into account.

Thank you @aitrics-ray for the discovery and quick iteration ❤️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2025

Overall package size

Self size: 9.28 MB
Deduped: 101.59 MB
No deduping: 102.11 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 3.1.0 | 2.37 MB | 2.52 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.24%. Comparing base (853152b) to head (87ae593).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5562   +/-   ##
=======================================
  Coverage   79.23%   79.24%           
=======================================
  Files         512      512           
  Lines       23232    23234    +2     
=======================================
+ Hits        18409    18411    +2     
  Misses       4823     4823           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Apr 10, 2025

Datadog Report

Branch report: fix-disable-mongo-hearbeats-spans
Commit report: 2fa1deb
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 929 Passed, 0 Skipped, 15m 32.57s Total Time

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 10, 2025

Benchmarks

Benchmark execution time: 2025-04-10 14:25:51

Comparing candidate commit 87ae593 in PR branch fix-disable-mongo-hearbeats-spans with baseline commit 853152b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 949 metrics, 14 unstable metrics.

@wconti27 wconti27 self-assigned this Apr 10, 2025
@wconti27 wconti27 marked this pull request as ready for review April 10, 2025 14:19
@wconti27 wconti27 requested review from a team as code owners April 10, 2025 14:19
@wconti27 wconti27 merged commit a59cfae into master Apr 10, 2025
427 checks passed
@wconti27 wconti27 deleted the fix-disable-mongo-hearbeats-spans branch April 10, 2025 14:46
github-actions Bot pushed a commit that referenced this pull request Apr 10, 2025
* Fix MongoDB heartbeat filtering when DD_TRACE_MONGODB_HEARTBEAT_ENABLED is set to 'false'

Co-authored-by: aitrics-ray <kyounghwan.choi@aitrics.com>
Co-authored-by: William Conti <william.conti@datadoghq.com>
This was referenced Apr 10, 2025
github-actions Bot pushed a commit that referenced this pull request Apr 10, 2025
* Fix MongoDB heartbeat filtering when DD_TRACE_MONGODB_HEARTBEAT_ENABLED is set to 'false'

Co-authored-by: aitrics-ray <kyounghwan.choi@aitrics.com>
Co-authored-by: William Conti <william.conti@datadoghq.com>
@github-actions github-actions Bot mentioned this pull request Apr 10, 2025
bengl pushed a commit that referenced this pull request Apr 11, 2025
* Fix MongoDB heartbeat filtering when DD_TRACE_MONGODB_HEARTBEAT_ENABLED is set to 'false'

Co-authored-by: aitrics-ray <kyounghwan.choi@aitrics.com>
Co-authored-by: William Conti <william.conti@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants