fix: reduce ACF overhead in storage and noop contexts#7465
Merged
Conversation
Replace manual enterWith/restore patterns with run() across all noop context wrappers (log writer, exporters, git utils). This halves AsyncContextFrame transitions on Node.js 22+: run() restores via AsyncContextFrame.set() (no extra frame), while enterWith/restore created a second frame that triggered the profiler's setContext() again. In DatadogStorage, feature-detect whether ALS.run() delegates to enterWith() (ACF behavior) and only fall back to the manual approach on older runtimes without AsyncContextFrame.
Contributor
Overall package sizeSelf size: 4.58 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-02-10 17:06:13 Comparing candidate commit b04c8bd in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 229 metrics, 31 unstable metrics. |
szegedi
requested changes
Feb 9, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7465 +/- ##
==========================================
- Coverage 80.34% 80.31% -0.04%
==========================================
Files 731 731
Lines 31093 31133 +40
==========================================
+ Hits 24982 25004 +22
- Misses 6111 6129 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
szegedi
previously approved these changes
Feb 10, 2026
simon-id
reviewed
Feb 10, 2026
rochdev
previously approved these changes
Feb 10, 2026
Member
rochdev
left a comment
rochdev
left a comment
There was a problem hiding this comment.
LGTM! Added a few comments but mostly just as notes.
| } | ||
|
|
||
| const hasExecArg = (arg) => process.execArgv.includes(arg) || String(NODE_OPTIONS).includes(arg) | ||
| const canUseAsyncContextFrame = samplingContextsAvailable && isACFActive |
Member
There was a problem hiding this comment.
Not a fan of exposing isACFActive as that should be a hidden implementation detail, but it seems better than the current alternative.
| als.run(1, () => {}) | ||
| als.disable() | ||
| return active | ||
| })() |
Member
There was a problem hiding this comment.
Doing this right at file load time can have side-effects, but I think that's fine because if this file is loaded then the rest of the library is probably loaded as well at which point we'll end up getting those side-effects anyway.
rochdev
approved these changes
Feb 10, 2026
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
* fix: reduce ACF overhead in storage and noop contexts Replace manual enterWith/restore patterns with run() across all noop context wrappers (log writer, exporters, git utils). This halves AsyncContextFrame transitions on Node.js 22+: run() restores via AsyncContextFrame.set() (no extra frame), while enterWith/restore created a second frame that triggered the profiler's setContext() again. In DatadogStorage, feature-detect whether ALS.run() delegates to enterWith() (ACF behavior) and only fall back to the manual approach on older runtimes without AsyncContextFrame. * doc: remove todo by explaining the behavior * fix: exclude node:internals ALS from path line detection (#7475)
juan-fernandez
pushed a commit
that referenced
this pull request
Feb 12, 2026
* fix: reduce ACF overhead in storage and noop contexts Replace manual enterWith/restore patterns with run() across all noop context wrappers (log writer, exporters, git utils). This halves AsyncContextFrame transitions on Node.js 22+: run() restores via AsyncContextFrame.set() (no extra frame), while enterWith/restore created a second frame that triggered the profiler's setContext() again. In DatadogStorage, feature-detect whether ALS.run() delegates to enterWith() (ACF behavior) and only fall back to the manual approach on older runtimes without AsyncContextFrame. * doc: remove todo by explaining the behavior * fix: exclude node:internals ALS from path line detection (#7475)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual enterWith/restore patterns with run() across all noop context wrappers (log writer, exporters, git utils). This halves AsyncContextFrame transitions on Node.js 22+: run() restores via AsyncContextFrame.set() (no extra frame), while enterWith/restore created a second frame that triggered the profiler's setContext() again.
In DatadogStorage, feature-detect whether ALS.run() delegates to enterWith() (ACF behavior) and only fall back to the manual approach on older runtimes without AsyncContextFrame.