fix(iast): Exclude node:internals ALS from path line detection#7475
Merged
CarlesDD merged 1 commit intoBridgeAR/2026-02-09-reduce-acf-triggersfrom Feb 10, 2026
Merged
Conversation
CarlesDD
changed the base branch from
master
to
BridgeAR/2026-02-09-reduce-acf-triggers
Contributor
Overall package sizeSelf size: 4.58 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
BenchmarksBenchmark execution time: 2026-02-10 16:07:55 Comparing candidate commit e475d02 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 233 metrics, 27 unstable metrics. |
simon-id
approved these changes
Feb 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## BridgeAR/2026-02-09-reduce-acf-triggers #7475 +/- ##
===========================================================================
- Coverage 80.35% 80.31% -0.04%
===========================================================================
Files 731 731
Lines 31089 31133 +44
===========================================================================
+ Hits 24981 25005 +24
- Misses 6108 6128 +20 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CarlesDD
merged commit b04c8bd
into
BridgeAR/2026-02-09-reduce-acf-triggers
1197 of 1204 checks passed
BridgeAR
added a commit
that referenced
this pull request
Feb 10, 2026
* fix: reduce ACF overhead in storage and noop contexts Replace manual enterWith/restore patterns with run() across all noop context wrappers (log writer, exporters, git utils). This halves AsyncContextFrame transitions on Node.js 22+: run() restores via AsyncContextFrame.set() (no extra frame), while enterWith/restore created a second frame that triggered the profiler's setContext() again. In DatadogStorage, feature-detect whether ALS.run() delegates to enterWith() (ACF behavior) and only fall back to the manual approach on older runtimes without AsyncContextFrame. * doc: remove todo by explaining the behavior * fix: exclude node:internals ALS from path line detection (#7475)
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
* fix: reduce ACF overhead in storage and noop contexts Replace manual enterWith/restore patterns with run() across all noop context wrappers (log writer, exporters, git utils). This halves AsyncContextFrame transitions on Node.js 22+: run() restores via AsyncContextFrame.set() (no extra frame), while enterWith/restore created a second frame that triggered the profiler's setContext() again. In DatadogStorage, feature-detect whether ALS.run() delegates to enterWith() (ACF behavior) and only fall back to the manual approach on older runtimes without AsyncContextFrame. * doc: remove todo by explaining the behavior * fix: exclude node:internals ALS from path line detection (#7475)
Merged
juan-fernandez
pushed a commit
that referenced
this pull request
Feb 12, 2026
* fix: reduce ACF overhead in storage and noop contexts Replace manual enterWith/restore patterns with run() across all noop context wrappers (log writer, exporters, git utils). This halves AsyncContextFrame transitions on Node.js 22+: run() restores via AsyncContextFrame.set() (no extra frame), while enterWith/restore created a second frame that triggered the profiler's setContext() again. In DatadogStorage, feature-detect whether ALS.run() delegates to enterWith() (ACF behavior) and only fall back to the manual approach on older runtimes without AsyncContextFrame. * doc: remove todo by explaining the behavior * fix: exclude node:internals ALS from path line detection (#7475)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes