Skip to content

Bump version to 0.92.0#2283

Merged
bwoebi merged 2 commits intomasterfrom
release-0.92.0
Sep 26, 2023
Merged

Bump version to 0.92.0#2283
bwoebi merged 2 commits intomasterfrom
release-0.92.0

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Sep 25, 2023

++$version;

@bwoebi
Prepare release 0.92.0
03bf578 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi added this to the 0.92.0 milestone Sep 25, 2023
@bwoebi bwoebi requested review from a team as code owners September 25, 2023 16:46
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Sep 25, 2023 •
edited
Loading

Benchmarks

Benchmark execution time: 2023-09-26 14:56:54

Comparing candidate commit ef1af86 in PR branch release-0.92.0 with baseline commit e7eb13f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 0 unstable metrics.

Anilm3
Anilm3 previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@morrisonlevi
Copy link
Copy Markdown
Collaborator

morrisonlevi commented Sep 25, 2023

System tests has a repeated failure in there:

ValueError: Schema is invalid in logs/interfaces/agent/00008__api_v2_apmtelemetry.json

I didn't investigate further, I am about to go to a doctor appointment.

@Anilm3 Anilm3 dismissed their stale review September 25, 2023 19:58

Didn't notice system tests failure.

@bwoebi bwoebi force-pushed the release-0.92.0 branch 2 times, most recently from 96cae79 to ad8dab5 Compare September 26, 2023 14:23
@bwoebi
Update libdatadog submodule
ef1af86 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
morrisonlevi
morrisonlevi reviewed Sep 26, 2023
View reviewed changes
Comment thread components-rs/common.h
*/
const char *ptr;
/**
* The number of elements (not bytes) that `.ptr` points to.
Copy link
Copy Markdown
Collaborator

@morrisonlevi morrisonlevi Sep 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in libdatadog I should modify this to say:

The number of elements (not bytes, unless they are the same for a given type) that .ptr points to.

Seems misleading for const char ^_^

Doesn't block this PR, definitely, just wanting your opinion.

Copy link
Copy Markdown
Collaborator Author

@bwoebi bwoebi Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care very much, but your edit is fine too :-D

morrisonlevi
morrisonlevi approved these changes Sep 26, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming the pending language tests pass.

Anilm3
Anilm3 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The system tests now pass locally with DataDog/system-tests#1624

@bwoebi bwoebi merged commit 14ec354 into master Sep 26, 2023
@bwoebi bwoebi deleted the release-0.92.0 branch September 26, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

@Anilm3 Anilm3 Anilm3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.92.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bwoebi @morrisonlevi @Anilm3