Skip to content

[Telemetry] Update required fields in metrics#1624

Merged
cbeauchesne merged 6 commits intomainfrom
anilm3/update-telemetry-schemas
Sep 27, 2023
Merged

[Telemetry] Update required fields in metrics#1624
cbeauchesne merged 6 commits intomainfrom
anilm3/update-telemetry-schemas

Conversation

@Anilm3
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 commented Sep 26, 2023

Description

Update telemetry metrics schemas:

  • Remove namespace from required fields in generate-metrics and choose relevant metric schema depending on the presence of the namespace property.
  • Add namespace as valid field to metric
  • Add metric schema with mandatory namespace field

As discussed with the Telemetry team, the namespace field is required either as part of individual series or as a top-level namespace, this change allows the validation of both options while ensuring the namespace is always available somewhere.

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@Anilm3 Anilm3 self-assigned this Sep 26, 2023
@Anilm3 Anilm3 marked this pull request as ready for review September 26, 2023 15:18
@Anilm3 Anilm3 requested a review from a team as a code owner September 26, 2023 15:18
@cbeauchesne
Copy link
Copy Markdown
Collaborator

@Anilm3 I guess it's an egg-chicken ? Do you want to merge this one before ?

@Anilm3
Copy link
Copy Markdown
Contributor Author

Anilm3 commented Sep 26, 2023

@Anilm3 I guess it's an egg-chicken ? Do you want to merge this one before ?

As discussed, the tests are working locally so this isn't blocking us any longer.

@cbeauchesne
Copy link
Copy Markdown
Collaborator

but it may block other PR on system tests, so the sooner the CI is green, the better.

@Anilm3 Anilm3 changed the title Update required fields in telemetry metrics [Telemetry] Update required fields in metrics Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants