Remove Serverless Specific Crates#1030
Merged
duncanpharvey merged 5 commits intomainfrom Apr 22, 2025
Merged
Conversation
BenchmarksComparisonBenchmark execution time: 2025-04-21 20:06:51 Comparing candidate commit a0aaeb3 in PR branch Found 0 performance improvements and 10 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:normalization/normalize_name/normalize_name/bad-name
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:normalization/normalize_service/normalize_service/[empty string]
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
- Coverage 71.55% 71.28% -0.28%
==========================================
Files 339 329 -10
Lines 50668 49186 -1482
==========================================
- Hits 36258 35063 -1195
+ Misses 14410 14123 -287
🚀 New features to boost your workflow:
|
7c68b9a to
d1f9fd2
Compare
…_allow_http_connections
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
ekump
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
serverlessandtrace-mini-agentcrates from libdatadog.Motivation
Move crates only used by Serverless to a separate repo.
https://datadoghq.atlassian.net/browse/SVLS-6543
Additional Notes
Migrated to serverless-components in these PRs:
How to test the change?