Skip to content

Remove Serverless Specific Crates#1030

Merged
duncanpharvey merged 5 commits intomainfrom
duncan-harvey/remove-serverless
Apr 22, 2025
Merged

Remove Serverless Specific Crates#1030
duncanpharvey merged 5 commits intomainfrom
duncan-harvey/remove-serverless

Conversation

@duncanpharvey
Copy link
Copy Markdown
Contributor

@duncanpharvey duncanpharvey commented Apr 18, 2025

What does this PR do?

Removes serverless and trace-mini-agent crates from libdatadog.

Motivation

Move crates only used by Serverless to a separate repo.

https://datadoghq.atlassian.net/browse/SVLS-6543

Additional Notes

Migrated to serverless-components in these PRs:

How to test the change?

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 18, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-04-21 20:06:51

Comparing candidate commit a0aaeb3 in PR branch duncan-harvey/remove-serverless with baseline commit a303dc1 in branch main.

Found 0 performance improvements and 10 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics.

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟥 execution_time [+1.274µs; +1.331µs] or [+6.832%; +7.140%]
  • 🟥 throughput [-3568361.956op/s; -3426093.216op/s] or [-6.653%; -6.388%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟥 execution_time [+1.077µs; +1.121µs] or [+9.844%; +10.245%]
  • 🟥 throughput [-8483755.759op/s; -8173466.772op/s] or [-9.283%; -8.944%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟥 execution_time [+33.007µs; +33.229µs] or [+6.551%; +6.595%]
  • 🟥 throughput [-122811.763op/s; -121998.748op/s] or [-6.188%; -6.147%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟥 execution_time [+9.056µs; +9.183µs] or [+5.099%; +5.171%]
  • 🟥 throughput [-276926.097op/s; -273154.129op/s] or [-4.918%; -4.851%]

scenario:normalization/normalize_service/normalize_service/[empty string]

  • 🟥 execution_time [+2.705µs; +2.757µs] or [+7.183%; +7.323%]
  • 🟥 throughput [-1813024.047op/s; -1779264.935op/s] or [-6.826%; -6.699%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.334µs 2.381µs ± 0.019µs 2.382µs ± 0.012µs 2.391µs 2.418µs 2.422µs 2.428µs 1.89% -0.065 0.445 0.79% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.378µs; 2.384µs] or [-0.110%; +0.110%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.890µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.917µs 3.919µs 3.920µs 0.18% -1.974 12.140 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 255086230.823op/s 255562603.572op/s ± 205781.682op/s 255555750.523op/s ± 93453.440op/s 255630445.592op/s 255934538.438op/s 256050464.990op/s 257038541.904op/s 0.58% 1.999 12.345 0.08% 14550.962op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.718µs 83.171µs ± 0.462µs 83.169µs ± 0.322µs 83.499µs 83.914µs 84.161µs 84.461µs 1.55% -0.150 0.209 0.55% 0.033µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11839813.005op/s 12023746.102op/s ± 66856.847op/s 12023753.174op/s ± 46775.359op/s 12069014.924op/s 12128390.842op/s 12182907.798op/s 12237236.941op/s 1.78% 0.186 0.242 0.55% 4727.493op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 78.572µs 79.440µs ± 0.469µs 79.398µs ± 0.343µs 79.762µs 80.307µs 80.549µs 80.631µs 1.55% 0.385 -0.473 0.59% 0.033µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12402104.578op/s 12588554.658op/s ± 74095.061op/s 12594732.255op/s ± 54567.125op/s 12648169.289op/s 12699930.739op/s 12722166.797op/s 12727229.018op/s 1.05% -0.361 -0.498 0.59% 5239.312op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.919µs 3.922µs 3.923µs 0.27% -0.477 6.656 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254882886.997op/s 255533814.651op/s ± 202588.239op/s 255559302.181op/s ± 89195.956op/s 255626693.819op/s 255820578.740op/s 255991995.495op/s 256749003.139op/s 0.47% 0.497 6.748 0.08% 14325.152op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 74.952µs 76.211µs ± 0.499µs 76.261µs ± 0.359µs 76.559µs 77.028µs 77.183µs 77.338µs 1.41% -0.140 -0.557 0.65% 0.035µs 1 200
credit_card/is_card_number/378282246310005 throughput 12930312.918op/s 13122085.606op/s ± 85951.934op/s 13112788.329op/s ± 61733.019op/s 13186014.708op/s 13272730.389op/s 13316046.092op/s 13341819.138op/s 1.75% 0.168 -0.544 0.65% 6077.720op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.344µs 51.423µs ± 0.034µs 51.424µs ± 0.020µs 51.443µs 51.482µs 51.497µs 51.527µs 0.20% 0.054 -0.013 0.07% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19407471.001op/s 19446594.785op/s ± 12733.266op/s 19446048.884op/s ± 7416.555op/s 19453814.214op/s 19468926.232op/s 19471112.184op/s 19476482.148op/s 0.16% -0.050 -0.016 0.07% 900.378op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.025µs 6.036µs ± 0.004µs 6.036µs ± 0.002µs 6.038µs 6.042µs 6.046µs 6.048µs 0.20% -0.143 1.808 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165332070.011op/s 165664849.502op/s ± 98616.307op/s 165669756.987op/s ± 41345.657op/s 165706151.841op/s 165811641.808op/s 165958392.250op/s 165983932.114op/s 0.19% 0.150 1.812 0.06% 6973.226op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.917µs 3.918µs 3.920µs 0.19% -1.346 6.917 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255084830.676op/s 255574106.081op/s ± 187282.481op/s 255560030.411op/s ± 94698.961op/s 255656698.278op/s 255905106.703op/s 256030867.790op/s 256743999.915op/s 0.46% 1.362 7.016 0.07% 13242.871op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.917µs 66.292µs ± 0.165µs 66.286µs ± 0.106µs 66.389µs 66.570µs 66.743µs 66.895µs 0.92% 0.628 1.179 0.25% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14948876.808op/s 15084933.932op/s ± 37404.802op/s 15086088.716op/s ± 24109.098op/s 15110874.175op/s 15141384.710op/s 15157011.552op/s 15170526.701op/s 0.56% -0.608 1.131 0.25% 2644.919op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.350µs 59.587µs ± 0.095µs 59.579µs ± 0.056µs 59.636µs 59.750µs 59.794µs 60.136µs 0.93% 1.141 4.577 0.16% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16629086.252op/s 16782309.322op/s ± 26725.245op/s 16784485.261op/s ± 15886.869op/s 16800153.301op/s 16818924.908op/s 16826444.815op/s 16849174.315op/s 0.39% -1.116 4.428 0.16% 1889.760op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.917µs 3.919µs 3.923µs 0.25% -1.983 13.238 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254906908.117op/s 255550765.079op/s ± 182351.214op/s 255538389.694op/s ± 72049.683op/s 255602996.946op/s 255874759.596op/s 256037461.877op/s 256864260.202op/s 0.52% 2.008 13.416 0.07% 12894.178op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.232µs 56.566µs ± 0.149µs 56.561µs ± 0.110µs 56.672µs 56.806µs 56.972µs 56.991µs 0.76% 0.279 -0.272 0.26% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17546654.522op/s 17678574.498op/s ± 46395.140op/s 17679925.329op/s ± 34393.557op/s 17714039.262op/s 17744841.126op/s 17768677.474op/s 17783384.512op/s 0.59% -0.266 -0.288 0.26% 3280.632op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.339µs 51.433µs ± 0.032µs 51.431µs ± 0.015µs 51.447µs 51.488µs 51.511µs 51.564µs 0.26% 0.214 1.990 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19393201.639op/s 19442688.335op/s ± 11952.864op/s 19443533.064op/s ± 5843.264op/s 19449034.777op/s 19460927.906op/s 19476081.096op/s 19478493.795op/s 0.18% -0.206 1.984 0.06% 845.195op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.026µs 6.036µs ± 0.005µs 6.036µs ± 0.002µs 6.038µs 6.044µs 6.047µs 6.048µs 0.20% 0.036 0.110 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165338718.366op/s 165674137.713op/s ± 125235.603op/s 165671479.665op/s ± 60892.818op/s 165732740.523op/s 165902135.173op/s 165947815.354op/s 165960059.413op/s 0.17% -0.031 0.108 0.08% 8855.494op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255534084.210op/s; 255591122.934op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [83.107µs; 83.235µs] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12014480.386op/s; 12033011.818op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [79.375µs; 79.505µs] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12578285.795op/s; 12598823.521op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255505737.869op/s; 255561891.432op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [76.142µs; 76.280µs] or [-0.091%; +0.091%] None None None
credit_card/is_card_number/378282246310005 throughput [13110173.495op/s; 13133997.718op/s] or [-0.091%; +0.091%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.418µs; 51.428µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19444830.077op/s; 19448359.493op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.036µs; 6.037µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 throughput [165651182.230op/s; 165678516.773op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255548150.530op/s; 255600061.632op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.269µs; 66.315µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15079749.986op/s; 15090117.877op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.574µs; 59.600µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16778605.460op/s; 16786013.184op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255525492.955op/s; 255576037.203op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.545µs; 56.587µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17672144.577op/s; 17685004.418op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.429µs; 51.438µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19441031.783op/s; 19444344.887op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.035µs; 6.037µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165656781.263op/s; 165691494.163op/s] or [-0.010%; +0.010%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.733µs 67.954µs ± 0.242µs 67.933µs ± 0.049µs 67.982µs 68.080µs 68.394µs 71.108µs 4.67% 11.170 142.108 0.36% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.920µs; 67.987µs] or [-0.049%; +0.049%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 213.461µs 213.927µs ± 0.161µs 213.909µs ± 0.097µs 214.015µs 214.235µs 214.283µs 214.350µs 0.21% 0.254 -0.000 0.08% 0.011µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4665267.087op/s 4674488.141op/s ± 3522.643op/s 4674877.223op/s ± 2120.743op/s 4676704.911op/s 4679897.452op/s 4682205.858op/s 4684696.502op/s 0.21% -0.249 -0.000 0.08% 249.088op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 19.701µs 19.947µs ± 0.204µs 19.861µs ± 0.090µs 20.060µs 20.311µs 20.583µs 21.200µs 6.74% 1.862 6.424 1.02% 0.014µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 47170789.570op/s 50137301.483op/s ± 504002.014op/s 50349069.501op/s ± 228707.732op/s 50512033.081op/s 50647920.078op/s 50724259.565op/s 50758045.150op/s 0.81% -1.721 5.337 1.00% 35638.324op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.262µs 12.041µs ± 0.155µs 12.068µs ± 0.091µs 12.137µs 12.253µs 12.271µs 12.303µs 1.94% -1.086 2.593 1.28% 0.011µs 1 200
normalization/normalize_name/normalize_name/good throughput 81281659.365op/s 83061376.842op/s ± 1085473.003op/s 82861898.205op/s ± 619533.515op/s 83624290.737op/s 84870158.333op/s 86215997.643op/s 88795160.664op/s 7.16% 1.226 3.336 1.30% 76754.532op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [213.905µs; 213.950µs] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4673999.936op/s; 4674976.345op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [19.919µs; 19.976µs] or [-0.142%; +0.142%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [50067451.651op/s; 50207151.315op/s] or [-0.139%; +0.139%] None None None
normalization/normalize_name/normalize_name/good execution_time [12.020µs; 12.063µs] or [-0.178%; +0.178%] None None None
normalization/normalize_name/normalize_name/good throughput [82910940.723op/s; 83211812.961op/s] or [-0.181%; +0.181%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 71.804ms 72.223ms ± 0.261ms 72.184ms ± 0.134ms 72.314ms 72.815ms 73.054ms 73.145ms 1.33% 1.256 1.753 0.36% 0.018ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.187ms; 72.259ms] or [-0.050%; +0.050%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 31.896µs 32.669µs ± 1.061µs 31.997µs ± 0.058µs 34.152µs 34.220µs 35.028µs 35.165µs 9.90% 0.961 -0.908 3.24% 0.075µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [32.522µs; 32.816µs] or [-0.450%; +0.450%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 148.130µs 148.882µs ± 0.345µs 148.812µs ± 0.178µs 149.034µs 149.495µs 150.061µs 150.628µs 1.22% 1.568 4.298 0.23% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [148.834µs; 148.930µs] or [-0.032%; +0.032%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.798µs 536.974µs ± 0.612µs 536.957µs ± 0.361µs 537.310µs 537.864µs 538.115µs 541.492µs 0.84% 2.068 13.577 0.11% 0.043µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1846749.954op/s 1862290.472op/s ± 2118.688op/s 1862345.295op/s ± 1252.156op/s 1863693.717op/s 1865295.758op/s 1866164.564op/s 1866374.195op/s 0.22% -2.030 13.238 0.11% 149.814op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 446.986µs 447.864µs ± 0.508µs 447.826µs ± 0.205µs 448.037µs 448.418µs 448.696µs 453.370µs 1.24% 6.384 67.047 0.11% 0.036µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2205703.221op/s 2232822.380op/s ± 2515.980op/s 2233010.641op/s ± 1020.584op/s 2233952.271op/s 2235529.572op/s 2236384.952op/s 2237206.785op/s 0.19% -6.288 65.694 0.11% 177.907op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 185.375µs 186.702µs ± 0.398µs 186.717µs ± 0.261µs 186.983µs 187.214µs 187.378µs 188.286µs 0.84% -0.345 1.492 0.21% 0.028µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5311083.434op/s 5356139.753op/s ± 11420.582op/s 5355705.903op/s ± 7475.188op/s 5362753.759op/s 5373822.831op/s 5389285.109op/s 5394480.125op/s 0.72% 0.366 1.486 0.21% 807.557op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 40.267µs 40.382µs ± 0.140µs 40.352µs ± 0.040µs 40.418µs 40.478µs 40.554µs 41.654µs 3.23% 7.378 63.775 0.35% 0.010µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 24007555.521op/s 24763601.578op/s ± 83756.992op/s 24782171.355op/s ± 24288.425op/s 24798554.185op/s 24816804.348op/s 24825963.506op/s 24834315.940op/s 0.21% -7.260 62.354 0.34% 5922.514op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.680µs 47.069µs ± 0.222µs 47.105µs ± 0.107µs 47.177µs 47.332µs 47.389µs 48.501µs 2.96% 2.002 11.956 0.47% 0.016µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20618298.763op/s 21245778.208op/s ± 99184.252op/s 21229384.091op/s ± 48375.985op/s 21322803.223op/s 21381545.518op/s 21411117.142op/s 21422476.510op/s 0.91% -1.865 10.973 0.47% 7013.386op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.889µs; 537.059µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1861996.843op/s; 1862584.102op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [447.794µs; 447.935µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2232473.689op/s; 2233171.070op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [186.647µs; 186.758µs] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5354556.971op/s; 5357722.536op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [40.363µs; 40.402µs] or [-0.048%; +0.048%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [24751993.665op/s; 24775209.492op/s] or [-0.047%; +0.047%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [47.038µs; 47.100µs] or [-0.065%; +0.065%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21232032.225op/s; 21259524.191op/s] or [-0.065%; +0.065%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.636µs 25.820µs ± 11.163µs 17.842µs ± 0.113µs 35.122µs 45.387µs 48.091µs 86.863µs 386.84% 1.678 4.811 43.13% 0.789µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.273µs; 27.367µs] or [-5.992%; +5.992%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.991ms 6.002ms ± 0.009ms 6.001ms ± 0.003ms 6.005ms 6.009ms 6.042ms 6.076ms 1.26% 5.113 36.614 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.001ms; 6.003ms] or [-0.020%; +0.020%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 254.838ns 264.398ns ± 10.442ns 260.164ns ± 3.086ns 267.853ns 289.987ns 293.801ns 295.994ns 13.77% 1.669 1.685 3.94% 0.738ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [262.951ns; 265.845ns] or [-0.547%; +0.547%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.888µs 4.953µs ± 0.045µs 4.939µs ± 0.028µs 4.985µs 5.029µs 5.033µs 5.046µs 2.18% 0.609 -1.152 0.90% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.947µs; 4.959µs] or [-0.125%; +0.125%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a0aaeb3 1745265262 duncan-harvey/remove-serverless
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.216µs 3.178µs ± 1.420µs 2.966µs ± 0.035µs 3.005µs 3.637µs 13.796µs 14.913µs 402.83% 7.363 55.373 44.58% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.982µs; 3.375µs] or [-6.193%; +6.193%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.28%. Comparing base (a303dc1) to head (a0aaeb3).
⚠️ Report is 589 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1030      +/-   ##
==========================================
- Coverage   71.55%   71.28%   -0.28%     
==========================================
  Files         339      329      -10     
  Lines       50668    49186    -1482     
==========================================
- Hits        36258    35063    -1195     
+ Misses      14410    14123     -287     
Components Coverage Δ
crashtracker 42.84% <ø> (+0.02%) ⬆️
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.01% <ø> (+0.18%) ⬆️
data-pipeline-ffi 90.30% <ø> (ø)
ddcommon 78.19% <ø> (-0.38%) ⬇️
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.19% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.41% <ø> (ø)
profiling 77.49% <ø> (ø)
profiling-ffi 62.12% <ø> (ø)
sidecar 42.08% <ø> (+0.26%) ⬆️
sidecar-ffi 9.34% <ø> (+2.04%) ⬆️
spawn-worker 54.37% <ø> (ø)
tinybytes 89.86% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 94.16% <ø> (-1.85%) ⬇️
trace-protobuf 78.50% <ø> (ø)
trace-utils 89.33% <ø> (-3.67%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@duncanpharvey duncanpharvey force-pushed the duncan-harvey/remove-serverless branch from 7c68b9a to d1f9fd2 Compare April 21, 2025 15:58
@r1viollet
Copy link
Copy Markdown
Contributor

r1viollet commented Apr 21, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.71 MB 23.71 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.70 MB 7.70 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 76.92 MB 76.92 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.31 MB 22.31 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 71.26 MB 71.26 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.63 MB 7.63 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.73 MB 16.73 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 112.72 MB 112.72 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 632.28 MB 632.28 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 4.99 MB 4.99 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.86 MB 15.86 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.39 MB 26.39 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.14 MB 14.14 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 114.61 MB 114.61 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 624.67 MB 624.67 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.77 MB 3.77 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.47 MB 16.47 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.31 MB 24.31 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 66.28 MB 66.28 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.18 MB 8.18 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.89 MB 22.89 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 67.25 MB 67.25 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.07 MB 8.07 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.54 MB 20.54 MB 0% (0 B) 👌

@github-actions github-actions Bot removed the common label Apr 21, 2025
@duncanpharvey duncanpharvey marked this pull request as ready for review April 21, 2025 19:55
@duncanpharvey duncanpharvey requested review from a team as code owners April 21, 2025 19:55
Copy link
Copy Markdown
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – :shipit: 😿

@duncanpharvey duncanpharvey merged commit 8f89f91 into main Apr 22, 2025
35 checks passed
@duncanpharvey duncanpharvey deleted the duncan-harvey/remove-serverless branch April 22, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants