fix(ddcommon): Add ubuntu ssl cert directory for unit test#1034
Merged
duncanpharvey merged 1 commit intomainfrom Apr 21, 2025
Merged
fix(ddcommon): Add ubuntu ssl cert directory for unit test#1034duncanpharvey merged 1 commit intomainfrom
duncanpharvey merged 1 commit intomainfrom
Conversation
…_allow_http_connections
BenchmarksComparisonBenchmark execution time: 2025-04-21 18:53:53 Comparing candidate commit 15c760d in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics. scenario:credit_card/is_card_number_no_luhn/ 378282246310005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
- Coverage 71.59% 71.58% -0.02%
==========================================
Files 339 339
Lines 50668 50668
==========================================
- Hits 36275 36269 -6
- Misses 14393 14399 +6
🚀 New features to boost your workflow:
|
ekump
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ubuntu ssl cert directory for
test_missing_root_certificates_only_allow_http_connections.Motivation
Test
test_missing_root_certificates_only_allow_http_connectionsfailing on ubuntu when ddcommon featureuse_webpki_rootsis disabled.Additional Notes
Follows #1033
Since
trace-mini-agentimports trace-utils with the mini_agent feature enabled, the use_webpki_roots feature is enabled for test runs. This means thattest_missing_root_certificates_use_webpki_certificatesruns in CI whiletest_missing_root_certificates_only_allow_http_connectionsdoes not run in CI, resulting in this test failure being hidden from past PRs.Following #1030 the default behavior will be to run
test_missing_root_certificates_only_allow_http_connectionsin CI.How to test the change?
Validated by applying this change and running CI in #1030.
https://github.com/DataDog/libdatadog/actions/runs/14579303934/job/40892263238?pr=1030