fix(datadog-trace-utils): [SVLS-7218] don't hardcode span type on all spans to serverless#1149
Merged
dd-mergequeue[bot] merged 1 commit intomainfrom Jul 22, 2025
Merged
Conversation
duncanpharvey
changed the title
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
+ Coverage 71.27% 71.31% +0.03%
==========================================
Files 345 345
Lines 53154 53148 -6
==========================================
+ Hits 37887 37903 +16
+ Misses 15267 15245 -22
🚀 New features to boost your workflow:
|
astuyve
approved these changes
Jul 21, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit 641cf12: What to do next?
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: rejected
mergequeue-status: queued
labels
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes hardcoding of span type on all spans to Serverless.
Motivation
https://datadoghq.atlassian.net/browse/SVLS-7218
While this may have been appropriate at the outset of the project where root spans had to manually be created for Azure Functions, it is no longer necessary due to the automatic instrumentation of http triggers and continuing work to auto instrument other types of triggers. There shouldn’t be any change where the root span is already of type
serverless.Additional Notes
How to test the change?
Deployed to Azure Functions and confirmed that span types set by tracer are not overridden.
Current:
Following this change: