Skip to content

fix(datadog-trace-utils): [SVLS-7218] don't hardcode span type on all spans to serverless #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dd-mergequeue merged 1 commit into from
Jul 22, 2025
Merged

fix(datadog-trace-utils): [SVLS-7218] don't hardcode span type on all spans to serverless #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion datadog-trace-utils/src/span/trace_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ mod tests {
span.meta.insert("origin".into(), "cloudfunction".into());
span.meta
.insert("functionname".into(), "dummy_function_name".into());
span.r#type = "serverless".into();
}
span
}
Expand Down
2 changes: 0 additions & 2 deletions datadog-trace-utils/src/test_utils/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ pub fn create_test_span(
"functionname".to_string(),
"dummy_function_name".to_string(),
);
span.r#type = "serverless".to_string();
}
span
}
Expand Down Expand Up @@ -185,7 +184,6 @@ pub fn create_test_gcp_span(
.insert("_dd.origin".to_string(), "cloudfunction".to_string());
span.meta
.insert("origin".to_string(), "cloudfunction".to_string());
span.r#type = "serverless".to_string();
}
span
}
Expand Down
3 changes: 0 additions & 3 deletions datadog-trace-utils/src/trace_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,6 @@ pub fn set_serverless_root_span_tags(
app_name: Option<String>,
env_type: &EnvironmentType,
) {
span.r#type = "serverless".to_string();
let origin_tag = match env_type {
EnvironmentType::CloudFunction => "cloudfunction",
EnvironmentType::AzureFunction => "azurefunction",
Expand Down Expand Up @@ -1043,7 +1042,6 @@ mod tests {
("service".to_string(), "test-service".to_string())
]),
);
assert_eq!(span.r#type, "serverless".to_string())
}

#[test]
Expand All @@ -1068,7 +1066,6 @@ mod tests {
("service".to_string(), "test-service".to_string())
]),
);
assert_eq!(span.r#type, "serverless".to_string())
}

#[test]
Expand Down
Loading