Skip to content

refactor(sidecar)!: Refactor tarpc away#1742

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 31 commits intomainfrom
bob/prevent-unprocessed
Mar 21, 2026
Merged

refactor(sidecar)!: Refactor tarpc away#1742
gh-worker-dd-mergequeue-cf854d[bot] merged 31 commits intomainfrom
bob/prevent-unprocessed

Conversation

@bwoebi
Copy link
Copy Markdown
Contributor

@bwoebi bwoebi commented Mar 16, 2026 •
edited
Loading

Everything we used tarpc for was dispatching ... and not much else.

But it also imposed some constraints on the messaging stream, like it did not directly allow us to backpressure directly on the read stream.

Finally, the old code, under some, not understood circumstances, would have file descriptors pile up in the sink, which were not ending up being associated with a message. (I suspect, when a message was dropped on the sender side?!)

This proposes a radically different approach based on message passing instead of streaming:

  • SOCK_SEQSTREAM is used on Linux.
    • Macos does not support this, so we fall back to a dgram socketpair, which results in the same thing, effectively.
  • Windows uses Named Pipe Messages.

The messaging approach promises to strongly tie file descriptors to the passed text, structurally eliminating the possibility of file descriptions leaking.

It also avoids a manual length delimiting codec and stream buffering. It generally avoids all buffering, except the send and receive buffers. In fact, previously we had multiple additional buffering channels around the different executors - and still, in the end we execute stuff serially...

Avoiding tarpc also allows us to trivially tie some metadata directly to the connection. This can still be improved upon. E.g. session_ids are now fundamentally tied to the connection.

Finally we also improve upon connection state stability when messages are dropped: the SidecarOutbox will buffer state-critical data and resubmit when space becomes available.

@bwoebi bwoebi requested review from a team as code owners March 16, 2026 22:14
@bwoebi bwoebi changed the title Refactor tarpc away refactor(sidecar)!: Refactor tarpc away Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 16, 2026 •
edited
Loading

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/bob/prevent-unprocessed

Summary by Rule

Rule Base Branch PR Branch Change
expect_used 3 4 ⚠️ +1 (+33.3%)
todo 1 1 No change (0%)
unwrap_used 43 30 ✅ -13 (-30.2%)
Total 47 35 ✅ -12 (-25.5%)

Annotation Counts by File

File Base Branch PR Branch Change
datadog-ipc/src/codec.rs 0 1 ⚠️ +1 (N/A)
datadog-ipc/src/example_interface.rs 3 1 ✅ -2 (-66.7%)
datadog-ipc/src/handles.rs 1 1 No change (0%)
datadog-ipc/src/platform/unix/channel.rs 1 0 ✅ -1 (-100.0%)
datadog-ipc/src/platform/unix/channel/async_channel.rs 3 0 ✅ -3 (-100.0%)
datadog-ipc/src/sequential.rs 1 0 ✅ -1 (-100.0%)
datadog-ipc/src/transport/mod.rs 2 0 ✅ -2 (-100.0%)
datadog-sidecar/src/config.rs 2 2 No change (0%)
datadog-sidecar/src/self_telemetry.rs 3 3 No change (0%)
datadog-sidecar/src/service/agent_info.rs 4 4 No change (0%)
datadog-sidecar/src/service/blocking.rs 2 1 ✅ -1 (-50.0%)
datadog-sidecar/src/service/session_info.rs 1 1 No change (0%)
datadog-sidecar/src/service/sidecar_server.rs 7 6 ✅ -1 (-14.3%)
datadog-sidecar/src/service/telemetry.rs 2 2 No change (0%)
datadog-sidecar/src/setup/windows.rs 2 0 ✅ -2 (-100.0%)
datadog-sidecar/src/shm_remote_config.rs 7 7 No change (0%)
datadog-sidecar/src/unix.rs 4 4 No change (0%)
libdd-telemetry/src/metrics.rs 2 2 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 21 20 ✅ -1 (-4.8%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 55 ✅ -4 (-6.8%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 8 8 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 200 195 ✅ -5 (-2.5%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@bwoebi bwoebi force-pushed the bob/prevent-unprocessed branch from e80e1ee to 78104b8 Compare March 16, 2026 22:19
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 16, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-03-21 04:37:26

Comparing candidate commit 35b13a1 in PR branch bob/prevent-unprocessed with baseline commit 5d5a596 in branch main.

Found 7 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:credit_card/is_card_number/ 378282246310005

  • 🟩 execution_time [-10.848µs; -10.683µs] or [-12.895%; -12.699%]
  • 🟩 throughput [+1731978.888op/s; +1756501.212op/s] or [+14.569%; +14.775%]

scenario:credit_card/is_card_number/x371413321323331

  • 🟩 execution_time [-593.861ns; -575.564ns] or [-9.224%; -8.940%]
  • 🟩 throughput [+15270698.117op/s; +15804357.385op/s] or [+9.831%; +10.175%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟩 execution_time [-598.614ns; -580.570ns] or [-9.299%; -9.018%]
  • 🟩 throughput [+15418289.119op/s; +15945238.210op/s] or [+9.926%; +10.265%]

scenario:two way interface

  • 🟩 execution_time [-12.905µs; -10.355µs] or [-50.396%; -40.438%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 728.596µs 730.331µs ± 0.732µs 730.275µs ± 0.418µs 730.707µs 731.392µs 732.383µs 733.889µs 0.49% 0.990 3.843 0.10% 0.052µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [730.230µs; 730.433µs] or [-0.014%; +0.014%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.379µs 2.422µs ± 0.017µs 2.423µs ± 0.014µs 2.436µs 2.448µs 2.452µs 2.459µs 1.46% -0.192 -0.822 0.72% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.420µs; 2.424µs] or [-0.100%; +0.100%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.307µs 185.707µs ± 0.223µs 185.678µs ± 0.169µs 185.857µs 186.082µs 186.296µs 186.450µs 0.42% 0.565 0.061 0.12% 0.016µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5363366.038op/s 5384823.046op/s ± 6468.665op/s 5385661.860op/s ± 4892.839op/s 5390104.611op/s 5393956.514op/s 5395254.679op/s 5396456.039op/s 0.20% -0.559 0.048 0.12% 457.404op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.871µs 17.970µs ± 0.047µs 17.961µs ± 0.024µs 17.991µs 18.053µs 18.108µs 18.263µs 1.68% 1.971 7.903 0.26% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54754760.788op/s 55647397.222op/s ± 144115.684op/s 55675119.306op/s ± 75197.980op/s 55745864.442op/s 55810432.377op/s 55866614.974op/s 55957367.070op/s 0.51% -1.924 7.572 0.26% 10190.518op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.135µs 10.239µs ± 0.037µs 10.240µs ± 0.026µs 10.264µs 10.298µs 10.319µs 10.353µs 1.11% 0.081 0.133 0.36% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 96589370.779op/s 97662344.445op/s ± 351844.211op/s 97660476.701op/s ± 250655.425op/s 97918453.958op/s 98195603.714op/s 98514741.014op/s 98669531.073op/s 1.03% -0.058 0.125 0.36% 24879.143op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.676µs; 185.738µs] or [-0.017%; +0.017%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5383926.551op/s; 5385719.541op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.964µs; 17.977µs] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55627424.175op/s; 55667370.270op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.234µs; 10.245µs] or [-0.050%; +0.050%] None None None
normalization/normalize_name/normalize_name/good throughput [97613582.221op/s; 97711106.669op/s] or [-0.050%; +0.050%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 239.074ns 249.745ns ± 13.892ns 243.761ns ± 3.027ns 248.349ns 283.452ns 288.874ns 291.067ns 19.41% 1.768 1.726 5.55% 0.982ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [247.820ns; 251.670ns] or [-0.771%; +0.771%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.864µs 34.393µs ± 0.865µs 33.996µs ± 0.042µs 34.064µs 36.242µs 36.269µs 37.162µs 9.31% 1.711 1.048 2.51% 0.061µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.274µs; 34.513µs] or [-0.349%; +0.349%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 13.008ms 13.041ms ± 0.016ms 13.040ms ± 0.011ms 13.050ms 13.069ms 13.091ms 13.107ms 0.51% 0.889 1.695 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [13.039ms; 13.044ms] or [-0.017%; +0.017%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 49.314ms 49.658ms ± 0.821ms 49.565ms ± 0.055ms 49.612ms 49.711ms 53.695ms 59.038ms 19.11% 9.151 91.957 1.65% 0.058ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [49.544ms; 49.772ms] or [-0.229%; +0.229%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.701µs 161.500µs ± 0.370µs 161.470µs ± 0.167µs 161.648µs 161.934µs 162.175µs 165.226µs 2.33% 5.199 49.867 0.23% 0.026µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.449µs; 161.552µs] or [-0.032%; +0.032%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.414µs 146.214µs ± 1.651µs 145.874µs ± 0.458µs 146.461µs 147.935µs 153.172µs 161.971µs 11.04% 5.581 44.090 1.13% 0.117µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [145.986µs; 146.443µs] or [-0.156%; +0.156%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2598 execution_time 3.563ms 3.589ms ± 0.012ms 3.588ms ± 0.007ms 3.595ms 3.611ms 3.621ms 3.644ms 1.58% 0.809 1.857 0.33% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2598 execution_time [3.587ms; 3.590ms] or [-0.046%; +0.046%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 5.291µs 5.392µs ± 0.019µs 5.394µs ± 0.009µs 5.403µs 5.418µs 5.429µs 5.433µs 0.71% -1.187 3.992 0.35% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [5.390µs; 5.395µs] or [-0.048%; +0.048%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 13.785µs 13.977µs ± 0.235µs 13.970µs ± 0.074µs 14.026µs 14.075µs 14.101µs 17.099µs 22.40% 11.750 153.692 1.68% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [13.944µs; 14.010µs] or [-0.233%; +0.233%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 190.870ns 192.623ns ± 1.640ns 192.305ns ± 1.237ns 193.586ns 195.593ns 197.492ns 200.531ns 4.28% 1.363 2.937 0.85% 0.116ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [192.396ns; 192.850ns] or [-0.118%; +0.118%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.155ms 14.204ms ± 0.030ms 14.200ms ± 0.012ms 14.213ms 14.260ms 14.310ms 14.376ms 1.24% 2.319 7.839 0.21% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.200ms; 14.208ms] or [-0.030%; +0.030%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 88.350µs 88.614µs ± 0.180µs 88.614µs ± 0.085µs 88.685µs 88.778µs 88.923µs 90.537µs 2.17% 6.137 63.745 0.20% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [88.589µs; 88.639µs] or [-0.028%; +0.028%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_timestamped_x1000 execution_time 4.190ms 4.195ms ± 0.008ms 4.194ms ± 0.002ms 4.196ms 4.199ms 4.201ms 4.295ms 2.41% 11.563 148.895 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_timestamped_x1000 execution_time [4.194ms; 4.196ms] or [-0.025%; +0.025%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.941µs 5.010µs ± 0.048µs 4.998µs ± 0.041µs 5.047µs 5.084µs 5.087µs 5.091µs 1.85% 0.285 -1.260 0.95% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.003µs; 5.017µs] or [-0.132%; +0.132%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.210ms 4.214ms ± 0.002ms 4.214ms ± 0.001ms 4.216ms 4.217ms 4.219ms 4.232ms 0.41% 2.310 15.669 0.05% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.214ms; 4.215ms] or [-0.007%; +0.007%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 495.347µs 496.159µs ± 0.786µs 496.091µs ± 0.242µs 496.309µs 496.817µs 497.179µs 505.029µs 1.80% 7.946 82.924 0.16% 0.056µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1980084.312op/s 2015488.916op/s ± 3151.738op/s 2015760.109op/s ± 982.779op/s 2016761.360op/s 2018169.852op/s 2018726.297op/s 2018787.736op/s 0.15% -7.844 81.311 0.16% 222.862op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 377.780µs 378.929µs ± 0.702µs 378.864µs ± 0.326µs 379.151µs 379.728µs 380.079µs 384.500µs 1.49% 4.324 30.680 0.18% 0.050µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2600781.705op/s 2639023.099op/s ± 4852.148op/s 2639472.753op/s ± 2275.565op/s 2641778.131op/s 2644026.717op/s 2645707.025op/s 2647040.816op/s 0.29% -4.247 29.920 0.18% 343.099op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 167.778µs 168.325µs ± 0.357µs 168.213µs ± 0.247µs 168.625µs 168.923µs 169.110µs 169.708µs 0.89% 0.728 0.034 0.21% 0.025µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5892472.517op/s 5940902.291op/s ± 12568.520op/s 5944842.099op/s ± 8751.577op/s 5951242.028op/s 5956207.057op/s 5959316.363op/s 5960252.049op/s 0.26% -0.719 0.002 0.21% 888.729op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 38.300µs 38.421µs ± 0.052µs 38.421µs ± 0.028µs 38.448µs 38.506µs 38.549µs 38.648µs 0.59% 0.665 2.396 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 25874874.717op/s 26027199.094op/s ± 35313.932op/s 26027108.488op/s ± 19030.366op/s 26048364.280op/s 26086883.895op/s 26100814.141op/s 26109993.222op/s 0.32% -0.649 2.344 0.14% 2497.072op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.168µs 46.276µs ± 0.051µs 46.264µs ± 0.027µs 46.301µs 46.358µs 46.431µs 46.519µs 0.55% 1.135 2.416 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21496782.768op/s 21609510.368op/s ± 23999.314op/s 21614886.607op/s ± 12695.280op/s 21624456.828op/s 21640198.140op/s 21653291.713op/s 21660201.498op/s 0.21% -1.124 2.373 0.11% 1697.008op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [496.050µs; 496.268µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2015052.115op/s; 2015925.717op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [378.832µs; 379.027µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2638350.638op/s; 2639695.560op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [168.276µs; 168.375µs] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5939160.415op/s; 5942644.167op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [38.414µs; 38.429µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26022304.923op/s; 26032093.265op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.269µs; 46.283µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21606184.294op/s; 21612836.442op/s] or [-0.015%; +0.015%] None None None

Group 20

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 35b13a1 1774066780 bob/prevent-unprocessed
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.917µs 3.917µs 0.15% -1.890 14.624 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255304099.932op/s 255667421.686op/s ± 171061.680op/s 255674355.863op/s ± 102914.451op/s 255774846.114op/s 255871438.982op/s 255923354.819op/s 256963205.422op/s 0.50% 1.916 14.860 0.07% 12095.887op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.382µs 79.846µs ± 0.272µs 79.808µs ± 0.151µs 79.958µs 80.342µs 80.801µs 81.202µs 1.75% 1.561 3.982 0.34% 0.019µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12314998.906op/s 12524206.804op/s ± 42452.796op/s 12530138.840op/s ± 23687.098op/s 12553155.729op/s 12576145.472op/s 12590727.145op/s 12597370.929op/s 0.54% -1.525 3.806 0.34% 3001.866op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 72.753µs 73.355µs ± 0.235µs 73.347µs ± 0.155µs 73.502µs 73.752µs 73.936µs 74.259µs 1.24% 0.331 0.467 0.32% 0.017µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13466291.170op/s 13632524.063op/s ± 43654.440op/s 13633797.695op/s ± 28763.553op/s 13662412.690op/s 13700410.738op/s 13713479.399op/s 13745221.780op/s 0.82% -0.309 0.426 0.32% 3086.835op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.916µs 3.917µs 3.919µs 0.19% -1.097 6.870 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255143013.349op/s 255638260.609op/s ± 184891.548op/s 255628898.862op/s ± 128647.334op/s 255767982.018op/s 255893052.626op/s 255967039.444op/s 256816359.323op/s 0.46% 1.114 6.984 0.07% 13073.807op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 69.678µs 70.131µs ± 0.260µs 70.084µs ± 0.178µs 70.296µs 70.581µs 70.728µs 71.077µs 1.42% 0.714 0.256 0.37% 0.018µs 1 200
credit_card/is_card_number/378282246310005 throughput 14069287.601op/s 14259233.285op/s ± 52645.121op/s 14268541.437op/s ± 36243.520op/s 14300350.732op/s 14326047.117op/s 14347857.901op/s 14351814.355op/s 0.58% -0.695 0.204 0.37% 3722.572op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.134µs 52.205µs ± 0.040µs 52.201µs ± 0.025µs 52.223µs 52.283µs 52.329µs 52.348µs 0.28% 1.011 1.148 0.08% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19103065.316op/s 19155445.265op/s ± 14775.693op/s 19156739.294op/s ± 9306.140op/s 19166443.869op/s 19173591.733op/s 19180290.410op/s 19181357.639op/s 0.13% -1.006 1.134 0.08% 1044.799op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.693µs 5.853µs ± 0.066µs 5.857µs ± 0.042µs 5.896µs 5.963µs 5.999µs 6.035µs 3.04% 0.051 -0.264 1.12% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165709310.686op/s 170863616.608op/s ± 1922732.669op/s 170743394.739op/s ± 1215329.035op/s 172437294.388op/s 173751772.694op/s 175159881.139op/s 175664374.513op/s 2.88% 0.007 -0.270 1.12% 135957.731op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.891µs 3.911µs ± 0.003µs 3.911µs ± 0.001µs 3.912µs 3.915µs 3.917µs 3.927µs 0.41% -0.810 20.736 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254679473.880op/s 255699066.084op/s ± 175619.526op/s 255721365.522op/s ± 69849.625op/s 255784926.991op/s 255876558.665op/s 255942305.444op/s 257036047.672op/s 0.51% 0.855 20.932 0.07% 12418.176op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.170µs 64.431µs ± 0.193µs 64.362µs ± 0.093µs 64.513µs 64.809µs 65.134µs 65.313µs 1.48% 1.582 2.980 0.30% 0.014µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15310976.233op/s 15520669.571op/s ± 46341.963op/s 15537113.533op/s ± 22454.152op/s 15554420.105op/s 15568121.857op/s 15575419.342op/s 15583539.108op/s 0.30% -1.560 2.871 0.30% 3276.872op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.372µs 57.576µs ± 0.135µs 57.552µs ± 0.080µs 57.649µs 57.832µs 57.996µs 58.084µs 0.92% 1.016 1.116 0.23% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17216475.811op/s 17368544.171op/s ± 40479.478op/s 17375506.618op/s ± 24219.343op/s 17399246.613op/s 17420283.481op/s 17427558.286op/s 17430244.961op/s 0.32% -1.001 1.072 0.23% 2862.331op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.914µs ± 0.002µs 3.914µs ± 0.001µs 3.915µs 3.916µs 3.917µs 3.918µs 0.10% -5.446 56.908 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255246004.701op/s 255508813.210op/s ± 120378.306op/s 255512916.178op/s ± 56969.419op/s 255563277.468op/s 255622707.847op/s 255652350.657op/s 256764668.699op/s 0.49% 5.487 57.447 0.05% 8512.032op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.590µs 54.862µs ± 0.236µs 54.762µs ± 0.106µs 55.018µs 55.338µs 55.505µs 55.693µs 1.70% 1.204 0.760 0.43% 0.017µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17955710.760op/s 18227920.866op/s ± 78027.790op/s 18260913.847op/s ± 35429.355op/s 18287079.875op/s 18305821.842op/s 18315451.412op/s 18318528.205op/s 0.32% -1.187 0.701 0.43% 5517.398op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.125µs 52.199µs ± 0.040µs 52.189µs ± 0.022µs 52.217µs 52.270µs 52.340µs 52.374µs 0.35% 1.499 3.323 0.08% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19093475.590op/s 19157463.400op/s ± 14551.104op/s 19160958.589op/s ± 8015.943op/s 19167141.769op/s 19174597.781op/s 19180667.327op/s 19184765.378op/s 0.12% -1.492 3.294 0.08% 1028.918op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.698µs 5.848µs ± 0.065µs 5.839µs ± 0.050µs 5.896µs 5.940µs 5.999µs 6.005µs 2.85% 0.047 -0.440 1.11% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 166522402.693op/s 171019002.107op/s ± 1896478.004op/s 171273751.291op/s ± 1441345.450op/s 172480126.951op/s 173967730.188op/s 175314804.719op/s 175489101.116op/s 2.46% 0.005 -0.446 1.11% 134101.246op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255643714.182op/s; 255691129.190op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [79.809µs; 79.884µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12518323.254op/s; 12530090.353op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [73.322µs; 73.387µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13626473.977op/s; 13638574.148op/s] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255612636.418op/s; 255663884.799op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [70.095µs; 70.167µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/378282246310005 throughput [14251937.178op/s; 14266529.393op/s] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.199µs; 52.210µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19153397.496op/s; 19157493.034op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.844µs; 5.862µs] or [-0.156%; +0.156%] None None None
credit_card/is_card_number/x371413321323331 throughput [170597144.352op/s; 171130088.864op/s] or [-0.156%; +0.156%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.910µs; 3.911µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255674726.907op/s; 255723405.261op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.404µs; 64.458µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15514247.021op/s; 15527092.121op/s] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.557µs; 57.594µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17362934.104op/s; 17374154.237op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.914µs; 3.914µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255492129.934op/s; 255525496.485op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.829µs; 54.895µs] or [-0.060%; +0.060%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18217106.965op/s; 18238734.767op/s] or [-0.059%; +0.059%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.194µs; 52.205µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19155446.757op/s; 19159480.043op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.839µs; 5.857µs] or [-0.154%; +0.154%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [170756168.495op/s; 171281835.719op/s] or [-0.154%; +0.154%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Mar 16, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 101.45 MB 101.45 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.70 MB 8.70 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.29 MB 11.29 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 118.20 MB 118.20 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.24 MB 27.24 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 80.34 KB 80.34 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 186.49 MB 186.48 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 918.02 MB 918.02 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.00 MB 9.00 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 80.34 KB 80.34 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 26.84 MB 26.84 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 60.83 MB 60.83 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.07 MB 23.07 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.59 KB 81.59 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.54 MB 190.54 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 903.03 MB 903.03 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.86 MB 6.86 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.59 KB 81.59 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 28.94 MB 28.94 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 57.20 MB 57.20 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 88.28 MB 88.28 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.28 MB 10.28 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 110.96 MB 110.96 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 12.02 MB 12.02 MB 0% (0 B) 👌

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 16, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 45.74819% with 823 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.33%. Comparing base (5d5a596) to head (35b13a1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
- Coverage   71.31%   70.33%   -0.99%     
==========================================
  Files         432      410      -22     
  Lines       64846    62123    -2723     
==========================================
- Hits        46246    43693    -2553     
+ Misses      18600    18430     -170
Components Coverage Δ
libdd-crashtracker 64.83% <ø> (-0.04%) ⬇️
libdd-crashtracker-ffi 34.09% <ø> (-0.39%) ⬇️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 87.73% <ø> (-0.11%) ⬇️
libdd-data-pipeline-ffi 74.15% <ø> (-0.59%) ⬇️
libdd-common 79.78% <ø> (ø)
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 70.51% <75.82%> (-9.79%) ⬇️
libdd-profiling 81.61% <ø> (ø)
libdd-profiling-ffi 64.94% <ø> (ø)
datadog-sidecar 30.61% <21.95%> (-1.30%) ⬇️
datdog-sidecar-ffi 8.62% <0.00%> (-1.67%) ⬇️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 92.26% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 88.95% <ø> (-0.14%) ⬇️
datadog-tracer-flare 86.88% <ø> (-3.59%) ⬇️
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bwoebi bwoebi force-pushed the bob/prevent-unprocessed branch from 78104b8 to b763a37 Compare March 17, 2026 13:38
@bwoebi bwoebi force-pushed the bob/prevent-unprocessed branch from b763a37 to 3e890d5 Compare March 17, 2026 14:04
Leiyks
Leiyks reviewed Mar 17, 2026
View reviewed changes
Comment thread datadog-ipc/src/codec.rs Outdated
Comment thread datadog-ipc/src/client.rs
Comment thread datadog-ipc/src/platform/unix/sockets/mod.rs
Comment thread datadog-ipc/src/codec.rs Outdated
bwoebi and others added 11 commits March 17, 2026 18:13
@bwoebi
WIP: Refactor tarpc away
00d5378 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

# Conflicts:
#	datadog-sidecar-ffi/src/lib.rs
#	datadog-sidecar/src/service/blocking.rs
#	datadog-sidecar/src/service/session_info.rs
#	datadog-sidecar/src/service/sidecar_interface.rs
#	datadog-sidecar/src/service/sidecar_server.rs
@bwoebi
Fixup windows
401824c
@bwoebi
macos is a special kind of snowflake
f5f040b 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi
Clippy
474efaa 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi
Fixup windows
51e66bb
@bwoebi
rm -rf / (not quite)
960b2f6 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi
fmt
cf553a9 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi
Add configurable size
88c3f07 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi
Add log message for size
1903e43 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi
Refactor ClearQueueId
16d7a00 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi
Cleanup outstanding
754b72b 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/prevent-unprocessed branch from 5b88525 to a648a78 Compare March 21, 2026 01:33
@bwoebi
clippy
c7448a2 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/prevent-unprocessed branch from 4055e9f to 36c217b Compare March 21, 2026 04:14
@bwoebi
Fix counter
35b13a1 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/prevent-unprocessed branch from 36c217b to 35b13a1 Compare March 21, 2026 04:19
@bwoebi
Copy link
Copy Markdown
Contributor Author

bwoebi commented Mar 21, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Mar 21, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-21 04:57:59 UTC ℹ️ Start processing command /merge

2026-03-21 04:58:04 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).

2026-03-21 05:33:15 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit c722b20 into main Mar 21, 2026
85 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bob/prevent-unprocessed branch March 21, 2026 05:33
This was referenced Mar 23, 2026
Closed
Merged
paullegranddc pushed a commit that referenced this pull request Mar 23, 2026
@dd-octo-sts
chore(release): proposal for libdd-data-pipeline (#1781)
f467132 
# Release proposal for libdd-data-pipeline and its dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-common
**Next version:** `3.0.1`

**Semver bump:** `patch`
**Tag:** `libdd-common-v3.0.1`

### Commits

- chore(build): update reqwest and quinn-proto dependency for dependabot
alert (#1774)
- chore(build): ekump/APMSP-2718 update aws-lc dependencies (#1751)
## libdd-trace-protobuf
**Next version:** `3.0.0`

**Semver bump:** `major`
**Tag:** `libdd-trace-protobuf-v3.0.0`

### Commits

- fix(trace-stats): rename wrongly cased stats fields (#1780)
- feat(rc)!: add process_tags to remote config Target (#1586)
## libdd-telemetry
**Next version:** `3.1.0`

**Semver bump:** `minor`
**Tag:** `libdd-telemetry-v3.1.0`

### Commits

- refactor(sidecar)!: Refactor tarpc away (#1742)
## libdd-trace-utils
**Next version:** `3.0.0`

**Semver bump:** `major`
**Tag:** `libdd-trace-utils-v3.0.0`

### Commits

- fix(trace-stats): rename wrongly cased stats fields (#1780)
- refactor(trace-utils)!: change header name type to accept dynamic
values (#1722)
## libdd-data-pipeline
**Next version:** `3.0.0`

**Semver bump:** `major`
**Tag:** `libdd-data-pipeline-v3.0.0`

### Commits

- feat(agents)!: retrieve container tags hash from /info endpoint
(#1700)
- refactor(trace-utils)!: change header name type to accept dynamic
values (#1722)

---------

Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>
iunanua pushed a commit that referenced this pull request Mar 24, 2026
@dd-octo-sts @iunanua
chore(release): proposal for libdd-data-pipeline (#1781)
1816bce 
# Release proposal for libdd-data-pipeline and its dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-common
**Next version:** `3.0.1`

**Semver bump:** `patch`
**Tag:** `libdd-common-v3.0.1`

### Commits

- chore(build): update reqwest and quinn-proto dependency for dependabot
alert (#1774)
- chore(build): ekump/APMSP-2718 update aws-lc dependencies (#1751)
## libdd-trace-protobuf
**Next version:** `3.0.0`

**Semver bump:** `major`
**Tag:** `libdd-trace-protobuf-v3.0.0`

### Commits

- fix(trace-stats): rename wrongly cased stats fields (#1780)
- feat(rc)!: add process_tags to remote config Target (#1586)
## libdd-telemetry
**Next version:** `3.1.0`

**Semver bump:** `minor`
**Tag:** `libdd-telemetry-v3.1.0`

### Commits

- refactor(sidecar)!: Refactor tarpc away (#1742)
## libdd-trace-utils
**Next version:** `3.0.0`

**Semver bump:** `major`
**Tag:** `libdd-trace-utils-v3.0.0`

### Commits

- fix(trace-stats): rename wrongly cased stats fields (#1780)
- refactor(trace-utils)!: change header name type to accept dynamic
values (#1722)
## libdd-data-pipeline
**Next version:** `3.0.0`

**Semver bump:** `major`
**Tag:** `libdd-data-pipeline-v3.0.0`

### Commits

- feat(agents)!: retrieve container tags hash from /info endpoint
(#1700)
- refactor(trace-utils)!: change header name type to accept dynamic
values (#1722)

---------

Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>
iunanua pushed a commit that referenced this pull request Mar 24, 2026
@dd-octo-sts @iunanua
chore(release): proposal for libdd-data-pipeline (#1781)
dfc4f08 
# Release proposal for libdd-data-pipeline and its dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-common
**Next version:** `3.0.1`

**Semver bump:** `patch`
**Tag:** `libdd-common-v3.0.1`

### Commits

- chore(build): update reqwest and quinn-proto dependency for dependabot
alert (#1774)
- chore(build): ekump/APMSP-2718 update aws-lc dependencies (#1751)
## libdd-trace-protobuf
**Next version:** `3.0.0`

**Semver bump:** `major`
**Tag:** `libdd-trace-protobuf-v3.0.0`

### Commits

- fix(trace-stats): rename wrongly cased stats fields (#1780)
- feat(rc)!: add process_tags to remote config Target (#1586)
## libdd-telemetry
**Next version:** `3.1.0`

**Semver bump:** `minor`
**Tag:** `libdd-telemetry-v3.1.0`

### Commits

- refactor(sidecar)!: Refactor tarpc away (#1742)
## libdd-trace-utils
**Next version:** `3.0.0`

**Semver bump:** `major`
**Tag:** `libdd-trace-utils-v3.0.0`

### Commits

- fix(trace-stats): rename wrongly cased stats fields (#1780)
- refactor(trace-utils)!: change header name type to accept dynamic
values (#1722)
## libdd-data-pipeline
**Next version:** `3.0.0`

**Semver bump:** `major`
**Tag:** `libdd-data-pipeline-v3.0.0`

### Commits

- feat(agents)!: retrieve container tags hash from /info endpoint
(#1700)
- refactor(trace-utils)!: change header name type to accept dynamic
values (#1722)

---------

Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>
This was referenced Mar 25, 2026
Closed
Closed
Closed
This was referenced Apr 8, 2026
Closed
Closed
Closed
iunanua added a commit that referenced this pull request Apr 14, 2026
@iunanua
ci: check major bumps in proposal workflow (#1851)
dd6b813 
# What does this PR do?

- Change `release-version-bumps` step to just bump versions and
propagate the bumps and commits info using `/tmp/api-changes.json` file
```json
[
  {
    "name": "libdd-common",
    "level": "patch",
    "tag": "libdd-common-v3.0.1",
    "prev_tag": "libdd-common-v3.0.0",
    "version": "3.0.1",
    "range": "c219ca2f9a2b0397a22dfe725738d5936b84047f..5ff99ff",
    "commits": [
      {
        "hash": "1cd2791f5e94ab3197e8e68bf6d670cc715d80a0",
        "subject": "chore(build): update reqwest and quinn-proto dependency for dependabot alert (#1774)",
        "author": "Edmund Kump",
        "date": "2026-03-22T19:00:19-04:00"
      },
      {
        "hash": "5d5a596b54b4bc3729063c30393e9706cf2d4eba",
        "subject": "chore(build): ekump/APMSP-2718 update aws-lc dependencies (#1751)",
        "author": "Edmund Kump",
        "date": "2026-03-20T14:36:31-04:00"
      }
    ],
    "path": "libdd-common",
    "initial_release": "false"
  },
  {
    "name": "libdd-telemetry",
    "level": "minor",
    "tag": "libdd-telemetry-v3.1.0",
    "prev_tag": "libdd-telemetry-v3.0.0",
    "version": "3.1.0",
    "range": "c8121f422d2c8d219f8d421ff3cdb1fcbe9e8b09..5ff99ff",
    "commits": [
      {
        "hash": "c722b209ece89f245da4d5c1f35e01914b27f315",
        "subject": "refactor(sidecar)!: Refactor tarpc away (#1742)",
        "author": "Bob Weinand",
        "date": "2026-03-21T06:33:10+01:00"
      }
    ],
    "path": "libdd-telemetry",
    "initial_release": "false"
  }
]
```

- Delay CHANGELOG generation
- Create a new step to check libdd-* dependency versions and bump
versions if needed:
- a /tmp/api-changes-with-major-bumps.json file is generated with the
version corrections
```json
[
  {
    "name": "libdd-common",
    "level": "patch",
    "tag": "libdd-common-v3.0.1",
    "prev_tag": "libdd-common-v3.0.0",
    "version": "3.0.1",
    "range": "c219ca2f9a2b0397a22dfe725738d5936b84047f..5ff99ff",
    "commits": [
      {
        "hash": "1cd2791f5e94ab3197e8e68bf6d670cc715d80a0",
        "subject": "chore(build): update reqwest and quinn-proto dependency for dependabot alert (#1774)",
        "author": "Edmund Kump",
        "date": "2026-03-22T19:00:19-04:00"
      },
      {
        "hash": "5d5a596b54b4bc3729063c30393e9706cf2d4eba",
        "subject": "chore(build): ekump/APMSP-2718 update aws-lc dependencies (#1751)",
        "author": "Edmund Kump",
        "date": "2026-03-20T14:36:31-04:00"
      }
    ],
    "path": "libdd-common",
    "initial_release": "false",
    "major_bumps": []
  },
  {
    "name": "libdd-telemetry",
    "level": "major",
    "tag": "libdd-telemetry-v4.0.0",
    "prev_tag": "libdd-telemetry-v3.0.0",
    "version": "4.0.0",
    "range": "c8121f422d2c8d219f8d421ff3cdb1fcbe9e8b09..5ff99ff",
    "commits": [
      {
        "hash": "c722b209ece89f245da4d5c1f35e01914b27f315",
        "subject": "refactor(sidecar)!: Refactor tarpc away (#1742)",
        "author": "Bob Weinand",
        "date": "2026-03-21T06:33:10+01:00"
      }
    ],
    "path": "libdd-telemetry",
    "initial_release": "false",
    "major_bumps": [
      {
        "dependency": "libdd-common",
        "previous_req": "^2.0.0",
        "current_req": "^3.0.1"
      }
    ]
  }
]
```
- CHANGELOG is generated with the final versions
- Reflect in the PR body that major bumps were forced in some crates 

# Notes
[Here](https://github.com/DataDog/libdatadog/actions/runs/23737121520)
one of the runs for the new workflow
[And here](#1818) the
resulting proposal PR
@Leiyks Leiyks mentioned this pull request Apr 15, 2026
Merged
Leiyks added a commit that referenced this pull request Apr 15, 2026
@Leiyks
test(sidecar): re-enable test_ddog_sidecar_register_app on Windows
ee8fb59 
APMSP-2356: the tarpc refactor (#1742) introduced a PID handshake in
SeqpacketConn::connect() — the blocking ReadFile waiting for the server's
4-byte PID acts as an implicit readiness barrier, eliminating the startup
race that caused intermittent failures.
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Apr 15, 2026
@Leiyks
fix(sidecar): enable test_ddog_sidecar_register_app on Windows (APMSP…
d1aa313 
…-2356) (#1848)

## Problem

\`test_ddog_sidecar_register_app\` was suppressed on Windows with \`#[ignore]\` (APMSP-2356) because it was intermittently failing due to a startup race on named pipes: the parent process could call \`CreateFileA\` before the child sidecar had called \`ConnectNamedPipe\`, causing \`ERROR_PIPE_BUSY\`.

## Root cause fix (already landed)

The tarpc refactor (#1742) introduced a **PID handshake** in \`SeqpacketConn::connect()\`: after \`CreateFileA\` returns, the client immediately calls \`ReadFile\` to receive a 4-byte server PID written by the server's \`try_accept()\`. That blocking \`ReadFile\` is an implicit readiness barrier — the parent can only proceed once the child has started its Tokio runtime, called \`ConnectNamedPipe\`, and written the PID. The race condition no longer exists.

The test has been validated to pass 20/20 times in Windows CI.

Co-authored-by: alexandre.rulleau <alexandre.rulleau@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leiyks Leiyks Leiyks approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done sidecar telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bwoebi @codecov-commenter @Leiyks