fix(sidecar): enable test_ddog_sidecar_register_app on Windows (APMSP-2356)#1848
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom Apr 15, 2026
Conversation
Leiyks
force-pushed
the
leiyks/fix-apmsp-2356-windows-pipe-race
branch
from
6bd5773 to
ba5ba4b
Compare
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: ee8fb59 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1848 +/- ##
==========================================
+ Coverage 71.64% 71.70% +0.05%
==========================================
Files 430 430
Lines 68806 68806
==========================================
+ Hits 49297 49335 +38
+ Misses 19509 19471 -38
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Leiyks
changed the title
Leiyks
force-pushed
the
leiyks/fix-apmsp-2356-windows-pipe-race
branch
from
485fe3a to
a77297a
Compare
Leiyks
force-pushed
the
leiyks/fix-apmsp-2356-windows-pipe-race
branch
from
2c29f5d to
b98b4f9
Compare
Leiyks
changed the title
Leiyks
force-pushed
the
leiyks/fix-apmsp-2356-windows-pipe-race
branch
from
b98b4f9 to
64185b0
Compare
APMSP-2356: the tarpc refactor (#1742) introduced a PID handshake in SeqpacketConn::connect() — the blocking ReadFile waiting for the server's 4-byte PID acts as an implicit readiness barrier, eliminating the startup race that caused intermittent failures.
Leiyks
force-pushed
the
leiyks/fix-apmsp-2356-windows-pipe-race
branch
from
f990d6b to
ee8fb59
Compare
bwoebi
approved these changes
Apr 15, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
leiyks/fix-apmsp-2356-windows-pipe-race
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`test_ddog_sidecar_register_app` was suppressed on Windows with `#[ignore]` (APMSP-2356) because it was intermittently failing due to a startup race on named pipes: the parent process could call `CreateFileA` before the child sidecar had called `ConnectNamedPipe`, causing `ERROR_PIPE_BUSY`.
Root cause fix (already landed)
The tarpc refactor (#1742) introduced a PID handshake in `SeqpacketConn::connect()`: after `CreateFileA` returns, the client immediately calls `ReadFile` to receive a 4-byte server PID written by the server's `try_accept()`. That blocking `ReadFile` is an implicit readiness barrier — the parent can only proceed once the child has started its Tokio runtime, called `ConnectNamedPipe`, and written the PID. The race condition no longer exists.
The test has been validated to pass 20/20 times in Windows CI.