Skip to content

Start using AsyncContextFrame already on Node.js 22 #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szegedi merged 4 commits into from
Dec 11, 2025
Merged

Start using AsyncContextFrame already on Node.js 22 #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a244a35
Start using AsyncContextFrame already on Node.js 22.7.0
szegedi Nov 28, 2025
aeecd95
Revert "Missed adding getMetrics in one spot (#237)"
szegedi Dec 1, 2025
d900d8c
Fixes for CPED not working on Windows
szegedi Dec 9, 2025
0b55bf5
Merge branch 'main' into szegedi/cped-22-2
szegedi Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions bindings/profilers/wall.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,25 @@ struct TimeTicks {
static int64_t Now();
};
} // namespace base
#if NODE_MAJOR_VERSION >= 24
#if NODE_MAJOR_VERSION >= 22

// Available from 22.7.0
#define DD_WALL_USE_CPED true

namespace internal {
#if NODE_MAJOR_VERSION == 24
#if NODE_MAJOR_VERSION < 25
struct HandleScopeData {
v8::internal::Address* next;
v8::internal::Address* limit;
};
#endif
#endif // NODE_MAJOR_VERSION < 25
#if NODE_MAJOR_VERSION >= 24
constexpr int kHandleBlockSize = v8::internal::KB - 2;
#endif // NODE_MAJOR_VERSION >= 24
} // namespace internal
#endif
#else // NODE_MAJOR_VERSION >= 22
#define DD_WALL_USE_CPED false
#endif //
} // namespace v8

static int64_t Now() {
Expand All @@ -61,18 +69,14 @@ static int64_t Now() {

#else
#define DD_WALL_USE_SIGPROF false
#define DD_WALL_USE_CPED false

static int64_t Now() {
return 0;
};

#endif

#if NODE_MAJOR_VERSION >= 23
#define DD_WALL_USE_CPED true
#else
#define DD_WALL_USE_CPED false
#endif

using namespace v8;

namespace dd {
Expand Down Expand Up @@ -905,7 +909,12 @@ NAN_METHOD(WallProfiler::New) {
#if !DD_WALL_USE_CPED
if (useCPED) {
return Nan::ThrowTypeError(
"useCPED is not supported on this Node.js version.");
#ifndef _WIN32
"useCPED is not supported on this Node.js version."
#else
"useCPED is not supported on Windows."
#endif
);
}
#endif

Expand Down
1 change: 0 additions & 1 deletion ts/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ export const time = {
v8ProfilerStuckEventLoopDetected:
timeProfiler.v8ProfilerStuckEventLoopDetected,
getState: timeProfiler.getState,
getMetrics: timeProfiler.getMetrics,
constants: timeProfiler.constants,
};

Expand Down
6 changes: 4 additions & 2 deletions ts/test/test-time-profiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ import {satisfies} from 'semver';
import assert from 'assert';

const useCPED =
satisfies(process.versions.node, '>=24.0.0') &&
!process.execArgv.includes('--no-async-context-frame');
(satisfies(process.versions.node, '>=24.0.0') &&
!process.execArgv.includes('--no-async-context-frame')) ||
(satisfies(process.versions.node, '>=22.7.0') &&
process.execArgv.includes('--experimental-async-context-frame'));

const collectAsyncId = satisfies(process.versions.node, '>=24.0.0');

Expand Down
7 changes: 5 additions & 2 deletions ts/test/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ const intervalMicros = 10000;
const withContexts =
process.platform === 'darwin' || process.platform === 'linux';
const useCPED =
satisfies(process.versions.node, '>=24.0.0') &&
!process.execArgv.includes('--no-async-context-frame');
withContexts &&
((satisfies(process.versions.node, '>=24.0.0') &&
!process.execArgv.includes('--no-async-context-frame')) ||
(satisfies(process.versions.node, '>=22.7.0') &&
process.execArgv.includes('--experimental-async-context-frame')));
const collectAsyncId =
withContexts && satisfies(process.versions.node, '>=24.0.0');

Expand Down
7 changes: 5 additions & 2 deletions ts/test/worker2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ const withContexts =
process.platform === 'darwin' || process.platform === 'linux';

const useCPED =
satisfies(process.versions.node, '>=24.0.0') &&
!process.execArgv.includes('--no-async-context-frame');
withContexts &&
((satisfies(process.versions.node, '>=24.0.0') &&
!process.execArgv.includes('--no-async-context-frame')) ||
(satisfies(process.versions.node, '>=22.7.0') &&
process.execArgv.includes('--experimental-async-context-frame')));

const collectAsyncId =
withContexts && satisfies(process.versions.node, '>=24.0.0');
Expand Down