Conversation
… change dd-trace-js PR #6982 made DD_TRACING_ENABLED=0 disable the whole tracer module via NoopProxy, which also stops the profiler from starting. Switch node_heap, node_heap_oom, and node_wall_cpu to keep the proxy alive via DD_DYNAMIC_INSTRUMENTATION_ENABLED=true (on the allowlist from PR #7916) until dd-trace-js adds DD_PROFILING_ENABLED to that allowlist. Also disable telemetry: its beforeExit HTTP request allocates thousands of objects that dominated the heap snapshots and skewed percentage assertions in node_heap and node_heap_oom.
KowalskiThomas
approved these changes
Apr 27, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly node CI job has been failing on
node_heap,node_heap_oom, andnode_wall_cpuwithNo matching files found for *.pprof— no profile files were being produced at all. Root-caused to dd-trace-js PR #6982 (commita995feed41, merged 2026-01-22), which switched theDD_TRACE_ENABLEDlookup inpackages/dd-trace/src/index.jsfromgetEnvironmentVariabletogetValueFromEnvSources. The new helper resolves aliases, soDD_TRACING_ENABLED=0(declared as an alias ofDD_TRACE_ENABLEDinsupported-configurations.json) now flips the package export toNoopProxy— which means the profiler never starts.Fix:
DD_DYNAMIC_INSTRUMENTATION_ENABLED=trueto keep the real proxy alive (it's on the allowlist added in PR #7916) while leaving tracing off. MarkedTEMPORARYin the comment — the proper upstream fix is to addDD_PROFILING_ENABLEDto that same allowlist.DD_INSTRUMENTATION_TELEMETRY_ENABLED=false. With the tracer module now loaded, the telemetrybeforeExithandler fires a final HTTP request whose setup allocates thousands of small objects that dominated the heap snapshot —node_heap'sobjects/countprofile was 98% telemetry stacks, andnode_heap_oom'sspacepercentage drifted just outside the ±3% margin (93% vs expected 97%).Test plan
TEST_SCENARIOS='node_(heap|heap_oom|wall_cpu)$' go test -timeout 10m -v -run TestScenariospasses locally for all three scenariosnode_code_hotspots(unchanged) still passes