Skip to content

Fix node profiling scenarios broken by dd-trace-js DD_TRACING_ENABLED change #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szegedi merged 1 commit into from
Apr 27, 2026
+27 −0
Merged

Fix node profiling scenarios broken by dd-trace-js DD_TRACING_ENABLED change #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scenarios/node_heap/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,16 @@ ENV DD_PROFILING_PPROF_PREFIX="/app/data/profiles_"
ENV DD_PROFILING_EXPORTERS=file
ENV DD_PROFILING_ENABLED=1
ENV DD_TRACING_ENABLED=0
# TEMPORARY: Since dd-trace-js PR #6982, DD_TRACING_ENABLED=0 also disables the
# entire tracer module (NoopProxy), which prevents the profiler from starting.
# DD_DYNAMIC_INSTRUMENTATION_ENABLED=true is on the allowlist (added in PR #7916)
# that keeps the real proxy alive while tracing stays off. Remove once dd-trace-js
# adds DD_PROFILING_ENABLED to that allowlist.
ENV DD_DYNAMIC_INSTRUMENTATION_ENABLED=true
ENV DD_REMOTE_CONFIGURATION_ENABLED=0
# Disable telemetry so its beforeExit HTTP request doesn't allocate thousands
# of objects that dominate the heap snapshot and skew percentage assertions.
ENV DD_INSTRUMENTATION_TELEMETRY_ENABLED=false
ENV DD_PROFILING_PROFILERS=space
ENV DD_TRACE_DEBUG=1
CMD node --expose-gc -r dd-trace/init main.js
9 changes: 9 additions & 0 deletions scenarios/node_heap_oom/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,16 @@ ENV DD_PROFILING_PPROF_PREFIX="/app/data/profiles_"
ENV DD_PROFILING_EXPORTERS=file
ENV DD_PROFILING_ENABLED=1
ENV DD_TRACING_ENABLED=0
# TEMPORARY: Since dd-trace-js PR #6982, DD_TRACING_ENABLED=0 also disables the
# entire tracer module (NoopProxy), which prevents the profiler from starting.
# DD_DYNAMIC_INSTRUMENTATION_ENABLED=true is on the allowlist (added in PR #7916)
# that keeps the real proxy alive while tracing stays off. Remove once dd-trace-js
# adds DD_PROFILING_ENABLED to that allowlist.
ENV DD_DYNAMIC_INSTRUMENTATION_ENABLED=true
ENV DD_REMOTE_CONFIGURATION_ENABLED=0
# Disable telemetry so its beforeExit HTTP request doesn't allocate thousands
# of objects that dominate the heap snapshot and skew percentage assertions.
ENV DD_INSTRUMENTATION_TELEMETRY_ENABLED=false
ENV DD_PROFILING_PROFILERS=space
ENV DD_PROFILING_EXPERIMENTAL_OOM_MONITORING_ENABLED=1
ENV DD_TRACE_DEBUG=1
Expand Down
9 changes: 9 additions & 0 deletions scenarios/node_wall_cpu/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,16 @@ ENV DD_PROFILING_PPROF_PREFIX="/app/data/profiles_"
ENV DD_PROFILING_EXPORTERS=file
ENV DD_PROFILING_ENABLED=1
ENV DD_TRACING_ENABLED=0
# TEMPORARY: Since dd-trace-js PR #6982, DD_TRACING_ENABLED=0 also disables the
# entire tracer module (NoopProxy), which prevents the profiler from starting.
# DD_DYNAMIC_INSTRUMENTATION_ENABLED=true is on the allowlist (added in PR #7916)
# that keeps the real proxy alive while tracing stays off. Remove once dd-trace-js
# adds DD_PROFILING_ENABLED to that allowlist.
ENV DD_DYNAMIC_INSTRUMENTATION_ENABLED=true
ENV DD_REMOTE_CONFIGURATION_ENABLED=0
# Disable telemetry so its beforeExit HTTP request doesn't allocate objects
# that contaminate the profiles and skew percentage assertions.
ENV DD_INSTRUMENTATION_TELEMETRY_ENABLED=false
ENV DD_PROFILING_PROFILERS=wall
ENV DD_PROFILING_EXPERIMENTAL_CPU_ENABLED=1
ENV DD_TRACE_DEBUG=1
Expand Down
Loading