Skip to content

Fix getting rid from user-agent for cpp tracer#1453

Merged
smola merged 1 commit intomainfrom
smola/cpp-rid
Aug 4, 2023
Merged

Fix getting rid from user-agent for cpp tracer#1453
smola merged 1 commit intomainfrom
smola/cpp-rid

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Aug 3, 2023

Description

Fix getting rid from user-agent for cpp tracer.
It uses http_user_agent attribute.

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

It uses http_user_agent attribute.
@smola smola marked this pull request as ready for review August 3, 2023 08:58
@smola smola requested a review from a team as a code owner August 3, 2023 08:58
@smola smola merged commit 778a272 into main Aug 4, 2023
@smola smola deleted the smola/cpp-rid branch August 4, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants