Add wait conditions to check when setup is ready#1292
Closed
Conversation
1a25fd4 to
4c1b085
Compare
2234440 to
b9aed3b
Compare
57c45b8 to
4df2a1d
Compare
39765b6 to
cf74617
Compare
0b2b9a3 to
0f23c0f
Compare
0f23c0f to
74c1674
Compare
74c1674 to
1a08bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace setup sleep with precondition checks, which should generally be faster:
wait_conditions.py/make_distant_callverify the secondary request, then make sure it's compatible with the wait conditions.Supersedes:
Related:
ridfrom user-agent for cpp tracer #1453Motivation
Reviewer checklist
run-default-scenariolabelWorkflow
Once your PR is reviewed, you can merge it! ❤️