Skip to content

Add wait conditions to check when setup is ready#1292

Closed
smola wants to merge 12 commits intomainfrom
smola/wait-conditions
Closed

Add wait conditions to check when setup is ready#1292
smola wants to merge 12 commits intomainfrom
smola/wait-conditions

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Jun 26, 2023

Description

Replace setup sleep with precondition checks, which should generally be faster:

  • Wait for traces: Issues a final request and waits until its trace is received. It is assumed that traces for previous request will have been received by the time the last trace is received.
  • Wait for telemetry: Wait to receive 2 heartbeats after the last trace. This should be enough to have received metrics or other events generated by previous requests.
  • Wait for remote config: Wait until the number of required remote config messages for each scenario have been received.
  • Wait for DSM events (scenario: INTEGRATIONS)
  • Wait for profiling events (scenario: PROFILING)
  • Fallback timeouts
  • Wait for OTel
  • Wait for backend in E2E tests
  • Move most logic to wait_conditions.py
  • Make sure tests using /make_distant_call verify the secondary request, then make sure it's compatible with the wait conditions.
  • Add further documentation here about how all conditions work, how they relate to each other, and why they actually work.

Supersedes:

Related:

Motivation

Reviewer checklist

  • If this PR modifies anything else than strictly the default scenario, then remove the run-default-scenario label
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Remove the run-default-scenario label to run all scenarios (more info)

Once your PR is reviewed, you can merge it! ❤️

@smola smola force-pushed the smola/wait-conditions branch 2 times, most recently from 1a25fd4 to 4c1b085 Compare June 27, 2023 15:07
@smola smola force-pushed the smola/wait-conditions branch from 2234440 to b9aed3b Compare June 28, 2023 12:30
@smola smola force-pushed the smola/wait-conditions branch 2 times, most recently from 57c45b8 to 4df2a1d Compare July 3, 2023 14:58
@smola smola force-pushed the smola/wait-conditions branch 2 times, most recently from 39765b6 to cf74617 Compare July 5, 2023 08:24
@smola smola force-pushed the smola/wait-conditions branch 11 times, most recently from 0b2b9a3 to 0f23c0f Compare August 7, 2023 07:57
@smola smola force-pushed the smola/wait-conditions branch from 0f23c0f to 74c1674 Compare August 11, 2023 09:38
@smola smola force-pushed the smola/wait-conditions branch from 74c1674 to 1a08bd9 Compare August 14, 2023 13:43
@cbeauchesne cbeauchesne deleted the smola/wait-conditions branch June 26, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants