Skip to content

[Java][Ratpack] Avoid blocking in /make_distant_call#1460

Merged
smola merged 1 commit intomainfrom
smola/ratpack-async-distant-call
Aug 7, 2023
Merged

[Java][Ratpack] Avoid blocking in /make_distant_call#1460
smola merged 1 commit intomainfrom
smola/ratpack-async-distant-call

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Aug 4, 2023

Description

Use Promises for the block where it makes a request.

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

Use Promises for the block where it makes a request.
@smola smola added the java Pull requests that update Java code label Aug 4, 2023
@smola smola marked this pull request as ready for review August 4, 2023 12:30
@smola smola requested review from a team as code owners August 4, 2023 12:30
@smola smola requested a review from ValentinZakharov August 4, 2023 12:30
@smola smola merged commit eac4232 into main Aug 7, 2023
@smola smola deleted the smola/ratpack-async-distant-call branch August 7, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants