Skip to content

PROF-10329: Allow for string values in product enablement #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szegedi wants to merge 1 commit into from
Closed

PROF-10329: Allow for string values in product enablement #2891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,9 +623,10 @@ def test_app_started_product_disabled(self):
), f"Product information was expected in app-started event, but was missing in {data['log_filename']}"

for product, details in payload["products"].items():
assert (
details.get("enabled") is False
), f"Product information expected to indicate {product} is disabled, but found enabled"
assert details.get("enabled") in [
False,
"false",
], f"Product information expected to indicate {product} is disabled, but found enabled"

if not data_found:
raise ValueError("No telemetry data to validate on")
Expand Down