PROF-10329: Allow for string values in product enablement#2891
Closed
PROF-10329: Allow for string values in product enablement#2891
Conversation
…string value ("true"/"false"/"auto")
801ea7c to
4b25459
Compare
cbeauchesne
approved these changes
Aug 19, 2024
cbeauchesne
requested changes
Aug 19, 2024
Collaborator
cbeauchesne
left a comment
There was a problem hiding this comment.
This property should be a boolean
Collaborator
|
See #2893 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for string values in product enablement
Motivation
Profiling exposes a string instead of boolean for enablement as its values are "true", "false", and "auto" since DataDog/dd-trace-js#4592.
Changes
The relevant test now accepts both a boolean False as well as a string "false".
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present