Skip to content

PROF-10329: Allow for string values in product enablement#2891

Closed
szegedi wants to merge 1 commit intomainfrom
szegedi/fix-telemetry-for-4-state-profiling
Closed

PROF-10329: Allow for string values in product enablement#2891
szegedi wants to merge 1 commit intomainfrom
szegedi/fix-telemetry-for-4-state-profiling

Conversation

@szegedi
Copy link
Copy Markdown
Contributor

@szegedi szegedi commented Aug 19, 2024

Allow for string values in product enablement

Motivation

Profiling exposes a string instead of boolean for enablement as its values are "true", "false", and "auto" since DataDog/dd-trace-js#4592.

Changes

The relevant test now accepts both a boolean False as well as a string "false".

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@szegedi szegedi force-pushed the szegedi/fix-telemetry-for-4-state-profiling branch from 801ea7c to 4b25459 Compare August 19, 2024 12:20
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @paullegranddc

This property should be a boolean

@cbeauchesne
Copy link
Copy Markdown
Collaborator

See #2893

@cbeauchesne cbeauchesne deleted the szegedi/fix-telemetry-for-4-state-profiling branch August 19, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants