Skip to content

[nodejs] Skip failing test for APMAPI-213#2893

Merged
cbeauchesne merged 1 commit intomainfrom
cbeauchesne/APMAPI-213
Aug 19, 2024
Merged

[nodejs] Skip failing test for APMAPI-213#2893
cbeauchesne merged 1 commit intomainfrom
cbeauchesne/APMAPI-213

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne marked this pull request as ready for review August 19, 2024 14:32
@cbeauchesne cbeauchesne requested a review from a team as a code owner August 19, 2024 14:32
@cbeauchesne cbeauchesne merged commit 412461c into main Aug 19, 2024
@cbeauchesne cbeauchesne deleted the cbeauchesne/APMAPI-213 branch August 19, 2024 14:33
cbeauchesne added a commit that referenced this pull request Aug 20, 2024
cbeauchesne added a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant