Only upsert once for each distinct character group #714
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
.wdb.writedownmodeis set to`partbyfirstchar, there was a writedown happening for each unique sym, but the intended action was a writedown for each unique first character of syms.This commit addresses this by grouping the syms by first letter, then altering the where clause in the functional select to select the corresponding syms before upserting to disk.
The number of upserts now equals the number of distinct starting characters.