Skip to content

Only upsert once for each distinct character group #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanCheale merged 3 commits into from
Nov 21, 2025
Merged

Only upsert once for each distinct character group #714

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d348f13
Only upsert once for each distinct character group
j-muldoon Nov 19, 2025
af9fb4a
.Q.fu optimisation.
j-muldoon Nov 20, 2025
f690722
Reduced changes to upserttopartition
j-muldoon Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion code/processes/wdb.q
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ upserttopartition:{[dir;tablename;tabdata;pt;expttype;expt;writedownmode]
` sv .Q.par[dir;pt;tablename],(`$"_"^.Q.an .Q.an?"_" sv string `TORQNULLSYMBOL^ ensuresymlist[expt]),`];
.lg.o[`save;"saving ",(string tablename)," data to partition ",string directory];
/- selecting rows of table with matching partition
r:?[tabdata;$[writedownmode in `partbyenum`partbyfirstchar;enlist(in;first expttype;expt);{(x;y;(),z)}[in;;]'[expttype;expt]];0b;()];
r:?[tabdata;$[writedownmode in `partbyenum`partbyfirstchar;enlist(in;first expttype;enlist expt);
{(x;y;(),z)}[in;;]'[expttype;expt]];0b;()];
/- upsert selected data matched on partition to specific directory
.[upsert;(directory;r);{[e] .lg.e[`savetablesbypart;"Failed to save table to disk : ",e];'e}];
.lg.o[`track;"appending details to partsizes"];
Expand All @@ -168,6 +169,8 @@ savetablesbypart:{[dir;pt;forcesave;tablename;writedownmode]
if[writedownmode~`partbyenum;.merge.checkenumerabletype[tablename;extrapartitiontype]];
/- get list of distinct combinations for partition directories
extrapartitions:.merge.getextrapartitions[tablename;extrapartitiontype];
if[writedownmode~`partbyfirstchar;
extrapartitions:value extrapartitions group .Q.fu[{first each string x}; extrapartitions:raze extrapartitions]];
/- enumerate data to be upserted
enumdata:.Q.en[hdbsettings[`hdbdir];0!.save.manipulate[tablename;`. tablename]];
.lg.o[`save;"enumerated ",(string tablename)," table"];
Expand Down