Skip to content

chore: update default configuration and quality presets#3

Merged
DaymareOn merged 1 commit intoDaymareOn:mainfrom
KaninHop:update_configs_xml_defaults
Mar 29, 2026
Merged

chore: update default configuration and quality presets#3
DaymareOn merged 1 commit intoDaymareOn:mainfrom
KaninHop:update_configs_xml_defaults

Conversation

@KaninHop
Copy link
Copy Markdown
Contributor

@KaninHop KaninHop commented Mar 29, 2026

Updated the default configuration to increase num iterations to 16
Set maxSubSteps to 4 to match the default values in older versions of FSMP

Updated Reasonable and Quality presents to have values consistent with the base config

Updated quality to be a more appropriate incremental step up from reasonable

Summary by CodeRabbit

  • Chores
    • Physics solver parameters adjusted across all configuration presets for enhanced simulation calculations.
    • Rendering culling distance extended and frame time allocation modified in quality presets.
    • First-person view physics simulation now enabled in the Quality preset.
    • Solver settings optimized in the Reasonable preset.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e3d03d55-d97e-4875-bc45-fd0ce0fc9f4e

📥 Commits

Reviewing files that changed from the base of the PR and between c6889a6 and e246222.

📒 Files selected for processing (3)
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configs.xml
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Quality.xml
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Reasonable.xml

📝 Walkthrough

Walkthrough

Physics solver configuration parameters were adjusted across three XML files: the main configuration file increased iteration and substepping values, while Quality and Reasonable presets modified culling distances, iteration counts, frame time percentages, and first-person physics visibility settings.

Changes

Cohort / File(s) Summary
Main Solver Configuration
SKSE/Plugins/hdtSkinnedMeshConfigs/configs.xml
Increased numIterations from 8 to 16 and maxSubSteps from 1 to 4, enhancing physics solver precision and stability.
Quality Preset
SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Quality.xml
Increased minCullingDistance (300→500) and enabled 1st-person physics (disable1stPersonViewPhysics true→false); decreased percentageOfFrameTime (60→30) and numIterations (50→32) for performance/stability balance.
Reasonable Preset
SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Reasonable.xml
Increased minCullingDistance (300→500), numIterations (10→16), and maxSubSteps (2→4) for improved physics fidelity.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • DaymareOn

Poem

🐰 With whiskers twitching, solver settings dance,
Iterations doubled, physics given chance,
Substepping stronger, culling far and wide,
First-person physics joins the joyful ride,
Configs tuned with care—a rabbit's delight!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the primary change: updating default configuration and quality presets for physics solver parameters.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants