feat: Ensure Max Active Skeletons Slider can be adjusted even when Auto Adjust the max number of NPC's is disabled and Add Default Preset#6
Conversation
…et-and-always-enable-max-active-skelotons
📝 WalkthroughWalkthroughA new HDT-SMP physics configuration preset file (Default.xml) was added with comprehensive solver settings including logging, rotation clamping, culling distance, wind simulation, and performance parameters. The FSMPM script was updated to use this preset as the default and reorder MCM slider option creation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Source/Scripts/FSMPM.psc`:
- Line 21: sLastLoadedPresetName is being pre-seeded to "Default.xml" which only
affects the UI label but does not reflect the actual startup source (configs.xml
read in OnConfigInit); change the initialization so sLastLoadedPresetName is
empty by default and only set when a preset is actually loaded, or if you intend
Default.xml to be applied at startup, load presetFolder + "/Default.xml" during
initialization (e.g., in OnConfigInit) and then assign sLastLoadedPresetName
after successful load; update any logic that assumes sLastLoadedPresetName
indicates the active preset accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 87683d12-672c-44b4-b525-c044e7142cac
📒 Files selected for processing (4)
SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Default.xmlScripts/FSMPM.pexScripts/FSMPMPlayerScript.pexSource/Scripts/FSMPM.psc
|
Works great for me. We gotta test this to be 100% sure, but we might be able to get away with a lower default minCullingDistance since we use proper camera on-screen checks now. 500 is pretty good already though, just something to think about. |
Update the MCM so that the Max Active Skeletons option is always able to be adjusted even when auto adjust max number of ncp's is disabled.
Add the default.xml so users can go back to the default config
Summary by CodeRabbit
New Features
Changes