Skip to content

feat: Ensure Max Active Skeletons Slider can be adjusted even when Auto Adjust the max number of NPC's is disabled and Add Default Preset#6

Merged
DaymareOn merged 4 commits intoDaymareOn:mainfrom
KaninHop:feat/add-default-preset-and-always-enable-max-active-skelotons
Apr 12, 2026
Merged

feat: Ensure Max Active Skeletons Slider can be adjusted even when Auto Adjust the max number of NPC's is disabled and Add Default Preset#6
DaymareOn merged 4 commits intoDaymareOn:mainfrom
KaninHop:feat/add-default-preset-and-always-enable-max-active-skelotons

Conversation

@KaninHop
Copy link
Copy Markdown
Contributor

@KaninHop KaninHop commented Apr 6, 2026

Update the MCM so that the Max Active Skeletons option is always able to be adjusted even when auto adjust max number of ncp's is disabled.
Add the default.xml so users can go back to the default config

Skyrim Special Edition 4_11_2026 4_16_52 PM Skyrim Special Edition 4_11_2026 4_18_30 PM

Summary by CodeRabbit

  • New Features

    • Added a new default physics configuration preset featuring optimized HDT-SMP settings, including rotation clamping, NPC face part rendering, auto-adjustment of maximum active skeletons, performance tuning, and wind simulation support.
  • Changes

    • Updated default preset selection to automatically use the new configuration.
    • Reorganized physics settings menu layout for improved usability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 6, 2026

📝 Walkthrough

Walkthrough

A new HDT-SMP physics configuration preset file (Default.xml) was added with comprehensive solver settings including logging, rotation clamping, culling distance, wind simulation, and performance parameters. The FSMPM script was updated to use this preset as the default and reorder MCM slider option creation.

Changes

Cohort / File(s) Summary
HDT-SMP Configuration Preset
SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Default.xml
New XML preset defining complete HDT-SMP physics configuration including SMP logging, NPC face parts, rotation clamping with speed limits, culling distance, auto-adjustment of skeleton counts, physics solver parameters (iteration count, ERP, MLCP settings), and wind simulation behavior.
MCM Script Updates
Source/Scripts/FSMPM.psc
Changed default preset name from empty string to "Default.xml" and reordered MCM slider option creation for SliderMaxSkeletons to appear before auto-adjustment toggles, removing conditional visibility flag from its call site.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A preset bundled with care,
Default settings floating through the air,
Sliders reordered, just right,
Physics smooth as moonlight,
Configuration set in flight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately captures both main changes: adding a default preset and ensuring the max active skeletons slider is always enabled, matching the actual file modifications.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Source/Scripts/FSMPM.psc`:
- Line 21: sLastLoadedPresetName is being pre-seeded to "Default.xml" which only
affects the UI label but does not reflect the actual startup source (configs.xml
read in OnConfigInit); change the initialization so sLastLoadedPresetName is
empty by default and only set when a preset is actually loaded, or if you intend
Default.xml to be applied at startup, load presetFolder + "/Default.xml" during
initialization (e.g., in OnConfigInit) and then assign sLastLoadedPresetName
after successful load; update any logic that assumes sLastLoadedPresetName
indicates the active preset accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 87683d12-672c-44b4-b525-c044e7142cac

📥 Commits

Reviewing files that changed from the base of the PR and between c6ca608 and e9ca45d.

📒 Files selected for processing (4)
  • SKSE/Plugins/hdtSkinnedMeshConfigs/configsPresets/Default.xml
  • Scripts/FSMPM.pex
  • Scripts/FSMPMPlayerScript.pex
  • Source/Scripts/FSMPM.psc

Comment thread Source/Scripts/FSMPM.psc
@asdasdduck
Copy link
Copy Markdown

Works great for me.

We gotta test this to be 100% sure, but we might be able to get away with a lower default minCullingDistance since we use proper camera on-screen checks now. 500 is pretty good already though, just something to think about.

@KaninHop KaninHop changed the title feat: Ensure Max Active Skelotons Always Enabled and Add Default Preset feat: Ensure Max Active Skelotons Slider can be adjusted even when Auto Adjust the max number of NPC's is disabled and Add Default Preset Apr 11, 2026
@KaninHop KaninHop changed the title feat: Ensure Max Active Skelotons Slider can be adjusted even when Auto Adjust the max number of NPC's is disabled and Add Default Preset feat: Ensure Max Active Skeletons Slider can be adjusted even when Auto Adjust the max number of NPC's is disabled and Add Default Preset Apr 11, 2026
@DaymareOn DaymareOn merged commit 46f1d44 into DaymareOn:main Apr 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants