feat(5.1): Extract EvolutionModels into evolution/models.py#39
Merged
Deepfreezechill merged 3 commits intomainfrom Apr 3, 2026
Merged
feat(5.1): Extract EvolutionModels into evolution/models.py#39Deepfreezechill merged 3 commits intomainfrom
Deepfreezechill merged 3 commits intomainfrom
Conversation
- New: openspace/skill_engine/evolution/ package - New: evolution/models.py (89 lines) — EvolutionTrigger enum, EvolutionContext dataclass, _sanitize_skill_name(), _MAX_SKILL_NAME_LENGTH constant - Updated: evolver.py imports from .evolution.models (removed local definitions) - Updated: mcp/tool_handlers.py imports from new location - Updated: skill_engine/__init__.py re-exports point to evolution.models - Updated: RUNBOOK.yaml — P4 marked complete, P5 active - New: tests/test_evolution_models.py — 17 tests (enum, dataclass, sanitize, compat) - evolver.py: 1498 → ~1460 lines (-38 lines) - All 1,425 tests pass, 127 skipped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Opus 4.6 review flagged: constant only used inside _sanitize_skill_name which moved to evolution/models.py. Dead import removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic 5.1: Extract EvolutionModels
Changes
Backward Compatibility (3 import paths)
Review Results (/8eyes + /collab)
1,425 tests pass, 127 skipped