Skip to content

Epic 5.6: Evolver.py Facade — P5a Capstone (80% reduction)#44

Merged
Deepfreezechill merged 2 commits intomainfrom
epic/5.6-evolver-facade
Apr 6, 2026
Merged

Epic 5.6: Evolver.py Facade — P5a Capstone (80% reduction)#44
Deepfreezechill merged 2 commits intomainfrom
epic/5.6-evolver-facade

Conversation

@Deepfreezechill
Copy link
Copy Markdown
Owner

Epic 5.6 — Evolver.py Facade (P5a Capstone)

What

Extract last 2 implementations from evolver.py into evolution/formatting.py:

  • format_skill_dir_content: collect_skill_snapshot → prompt text
  • format_analysis_context: ExecutionAnalysis list → context block

Result

  • evolver.py: 1,498 → 302 lines (80% reduction)
  • evolver.py is now a pure delegation shell: init + thin delegates + staticmethod bindings
  • Zero implementation logic remains
  • 14 new tests in test_evolution_formatting.py

P5a Summary (Complete)

Epic Module Lines PR
5.1 evolution/models.py 89 #39
5.2 evolution/orchestrator.py 132 #40
5.3 evolution/triggers.py 380 #41
5.4 evolution/confirmation.py 175 #42
5.5 evolution/loop.py + strategies.py 640 #43
5.6 evolution/formatting.py 85 THIS PR

Review

  • /8eyes: Security PASS, impl PASS after unused import fix
  • /collab GPT-5.4: APPROVE after unused Any + logger cleanup
  • 1,576 passed, 127 skipped

Brian Krafft and others added 2 commits April 6, 2026 08:47
P5a capstone: evolver.py is now a pure delegation shell.

evolution/formatting.py (~85 lines):
  - format_skill_dir_content: multi-file skill directory → prompt text
  - format_analysis_context: execution analyses → prompt context block

evolver.py: 1,498 → 303 lines (80% reduction, zero implementation logic)
All methods are either __init__, thin delegates, or staticmethod bindings.
Unused imports removed (collect_skill_snapshot, SKILL_FILENAME, _ANALYSIS_CONTEXT_MAX).

15 new tests; 1,577 total pass, 127 skipped.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove unused typing.Any from evolver.py imports
- Remove unused Logger import and logger instance from formatting.py
- Remove test_logger_uses_evolver_namespace (tested dead code)
- 1,576 passed, 127 skipped

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

🔒 Phase Gate Enforcement — 🚫 FAIL

Check Result Detail
Issue linkage No linked issues found. PR must contain "Closes #N", "Fixes #N", or "Resolves #N".

Verdict: FAIL
Timestamp: 2026-04-06T15:54:58.410Z
Run: View workflow run


How to fix: Ensure all prerequisite phases are complete, or add emergency:bypass label with a ## Bypass Reason section in the PR body.

@Deepfreezechill Deepfreezechill merged commit 39724e6 into main Apr 6, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant