Epic 5.3: Extract trigger functions to evolution/triggers.py#41
Merged
Deepfreezechill merged 2 commits intomainfrom Apr 3, 2026
Merged
Epic 5.3: Extract trigger functions to evolution/triggers.py#41Deepfreezechill merged 2 commits intomainfrom
Deepfreezechill merged 2 commits intomainfrom
Conversation
- New: evolution/triggers.py (380 lines) — process_analysis, process_tool_degradation, process_metric_check, build_context_from_analysis, load_skill_content, diagnose_skill_health - Modified: evolver.py — 6 methods now delegate to triggers module (-230 lines, 44.7KB from 58KB) - Constants moved: _ANALYSIS_CONTEXT_MAX, thresholds (re-imported in evolver.py) - New: tests/test_evolution_triggers.py — 22 tests - Suite: 1,468 passed, 127 skipped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Review fixes from /8eyes + /collab gate: - Route helper calls through evolver._method() to preserve MRO (GPT-5.4 MEDIUM) - Add 2 happy-path tests: confirm->execute for triggers 2 & 3 (Opus M-2) - Remove unused import logging (Opus L-1) - Move _ANALYSIS_NOTE_MAX_CHARS to evolver.py where used (Opus L-2) - Restore diagnose_skill_health return type annotation (Opus L-3) 24 trigger tests pass; 1,470 total pass, 127 skipped. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic 5.3 — Evolution Triggers Extraction
Extracts 3 trigger functions + 3 helpers from evolver.py → evolution/triggers.py (~380 lines).
Extracted functions
Review gate (4 reviewers)
Key fix from review
Helper calls now route through \�volver._method()\ to preserve MRO/subclass overrides — same pattern established in 5.2.
Tests
Impact