Skip to content

Portal editor language text update for Ukranian and Italian #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ussaama merged 1 commit into from
Apr 14, 2026
Merged

Portal editor language text update for Ukranian and Italian #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions echo/frontend/src/components/project/ProjectPortalEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,8 +642,14 @@ const ProjectPortalEditorComponent: React.FC<ProjectPortalEditorProps> = ({
{ label: t`German`, value: "de" },
{ label: t`Spanish`, value: "es" },
{ label: t`French`, value: "fr" },
{ label: t`Italian`, value: "it" },
{ label: t`Ukrainian`, value: "uk" },
{
label: t`Italian (only ECHO features, Transcription and Summaries)`,
value: "it",
},
{
label: t`Ukrainian (only ECHO features, Transcription and Summaries)`,
value: "uk",
},
Comment on lines +645 to +652
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the new Italian/Ukrainian strings were extracted to .po files

echo "Checking for new language strings in .po catalogs..."

rg -n "Italian \(only ECHO features, Transcription and Summaries\)" echo/frontend/src/locales/ -A2 -B2

rg -n "Ukrainian \(only ECHO features, Transcription and Summaries\)" echo/frontend/src/locales/ -A2 -B2

Repository: Dembrane/echo

Length of output: 50370

Looks good—i18n extraction confirmed, but the copy is still verbose.

The Italian and Ukrainian strings are properly extracted to the .po files. However, the labels (~50 chars) are significantly longer than other options ("English" is 7 chars). Per style guide, aim for shortest copy with highest clarity.

Consider tightening to:

  • "Italian (Transcription & Summaries)"
  • "Ukrainian (Transcription & Summaries)"

Drops the internal jargon ("ECHO features") and keeps it scannable.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@echo/frontend/src/components/project/ProjectPortalEditor.tsx` around lines
645 - 652, In ProjectPortalEditor.tsx update the two locale option labels to
shorter, scannable text: replace the t`Italian (only ECHO features,
Transcription and Summaries)` and t`Ukrainian (only ECHO features, Transcription
and Summaries)` entries used when building the language options with t`Italian
(Transcription & Summaries)` and t`Ukrainian (Transcription & Summaries)`
respectively; keep the same value keys ("it", "uk") and leave the t`...` i18n
wrapper in place so extraction still works.

]}
{...field}
{...testId("portal-editor-language-select")}
Expand Down
154 changes: 81 additions & 73 deletions echo/frontend/src/locales/de-DE.po
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion echo/frontend/src/locales/de-DE.ts
View file
Open in desktop

Large diffs are not rendered by default.

154 changes: 81 additions & 73 deletions echo/frontend/src/locales/en-US.po
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion echo/frontend/src/locales/en-US.ts
View file
Open in desktop

Large diffs are not rendered by default.

154 changes: 81 additions & 73 deletions echo/frontend/src/locales/es-ES.po
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion echo/frontend/src/locales/es-ES.ts
View file
Open in desktop

Large diffs are not rendered by default.

154 changes: 81 additions & 73 deletions echo/frontend/src/locales/fr-FR.po
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion echo/frontend/src/locales/fr-FR.ts
View file
Open in desktop

Large diffs are not rendered by default.

154 changes: 81 additions & 73 deletions echo/frontend/src/locales/it-IT.po
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion echo/frontend/src/locales/it-IT.ts
View file
Open in desktop

Large diffs are not rendered by default.

154 changes: 81 additions & 73 deletions echo/frontend/src/locales/nl-NL.po
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion echo/frontend/src/locales/nl-NL.ts
View file
Open in desktop

Large diffs are not rendered by default.

154 changes: 81 additions & 73 deletions echo/frontend/src/locales/uk-UA.po
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion echo/frontend/src/locales/uk-UA.ts
View file
Open in desktop

Large diffs are not rendered by default.

Loading