Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Universal Robots asset download reference so consumers pull the updated UR5 material asset bundle via the dataset download mechanism.
Changes:
- Switched the Universal Robots asset archive from
UniversalRobots.ziptoUniversalRobots_v2.zip. - Updated the corresponding MD5 checksum for the new archive.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
309
to
313
| os.path.join( | ||
| EMBODICHAIN_DOWNLOAD_PREFIX, robot_assets, "UniversalRobots.zip" | ||
| EMBODICHAIN_DOWNLOAD_PREFIX, robot_assets, "UniversalRobots_v2.zip" | ||
| ), | ||
| "dbd12f7e36cef4e5025b82f748233b80", | ||
| "4dd4ee5a86125364a9e8cbcd4aafc31a", | ||
| ) |
There was a problem hiding this comment.
The archive name UniversalRobots_v2.zip is inconsistent with other versioned robot asset archives in this module (e.g., FrankaV2.zip, CobotMagicArmV2.zip). If the remote filename isn’t required to be exactly this, consider renaming to UniversalRobotsV2.zip for consistency; otherwise, add a short inline note explaining the naming difference to avoid confusion when future assets are bumped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update UR5 asset (material)
Type of change
Checklist
black .command to format the code base.