Skip to content

Update ur5 asset #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuecideng merged 2 commits into from
Mar 10, 2026
Merged

Update ur5 asset #167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
935ff02
wip
yuecideng Mar 9, 2026
d9853c5
Merge remote-tracking branch 'origin/main' into yueci/update-ur5-asset
yuecideng Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions embodichain/data/assets/robot_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,9 @@ class UniversalRobots(EmbodiChainDataset):
def __init__(self, data_root: str = None):
data_descriptor = o3d.data.DataDescriptor(
os.path.join(
EMBODICHAIN_DOWNLOAD_PREFIX, robot_assets, "UniversalRobots.zip"
EMBODICHAIN_DOWNLOAD_PREFIX, robot_assets, "UniversalRobots_v2.zip"
),
"dbd12f7e36cef4e5025b82f748233b80",
"4dd4ee5a86125364a9e8cbcd4aafc31a",
)
Comment on lines 309 to 313
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The archive name UniversalRobots_v2.zip is inconsistent with other versioned robot asset archives in this module (e.g., FrankaV2.zip, CobotMagicArmV2.zip). If the remote filename isn’t required to be exactly this, consider renaming to UniversalRobotsV2.zip for consistency; otherwise, add a short inline note explaining the naming difference to avoid confusion when future assets are bumped.

Copilot uses AI. Check for mistakes.
prefix = "UniversalRobots"
path = EMBODICHAIN_DEFAULT_DATA_ROOT if data_root is None else data_root
Expand Down