This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Exclusion pattern for video streaming for politiken.dk #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
added a commit
to jsha/https-everywhere
that referenced
this pull request
Mar 23, 2015
Per report in IRC, rule breaks streaming video. Possible fix at EFForg#1170, but not tested.
Merged
Contributor
Author
|
This one fails the test as it lacks some of the tests required for the February 2015 Travis test. In fact I'm not entirely sure what some of the rules do; I'll drop the original author a mail about it. |
Contributor
Author
|
In adding the various test criteria, I realized that I have no idea what the web.politiken.dk rule does. I asked the original author but did not hear back and so opted to simply remove that rule. |
Contributor
Author
|
Closing; largely superceded by #1230 (cf. the discussion there). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #1026. I suppose it would make sense to include the pattern again in a platform="mixedcontent" ruleset, but maybe that's a little excessive.