Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Conversation

@jsha
Copy link
Member

@jsha jsha commented Mar 23, 2015

Per report in IRC, rule breaks streaming video.

Possible fix at #1170,
but not tested.

cc @cooperq @diracdeltas for code review.

Per report in IRC, rule breaks streaming video.

Possible fix at EFForg#1170,
but not tested.
@jsha
Copy link
Member Author

jsha commented Mar 23, 2015

Merging as TBR (To Be Reviewed).

jsha added a commit that referenced this pull request Mar 23, 2015
@jsha jsha merged commit c3b04a0 into EFForg:master Mar 23, 2015
@cooperq
Copy link
Contributor

cooperq commented Mar 23, 2015

LGTM

@fuglede
Copy link
Contributor

fuglede commented Apr 5, 2015

I revamped the rule in #1170, including only the parts where it's clear what it does. Tried to get in touch with the original author without success, unfortunately.

Anyway, my guess is that the site is probably either the most popular or second most popular Danish news site among https-e users so having any kind of covering would be very beneficial.

@jsha
Copy link
Member Author

jsha commented Apr 5, 2015

Thanks! Sorry I missed that pull request for so long. Can you merge latest master and confirm that it still fixes streaming video?

@fuglede
Copy link
Contributor

fuglede commented Apr 8, 2015

No problem; I could have certainly timed that better.

But good thing you asked: they've changed their design recently and it seems like the URL pattern for pages with video streams have changed so that the old fix no longer applies (or I might have simply missed those before). Roughly: before, video pages were all called politiken.dk/tv/..., but now some individual articles also include videos. On the bottom line, the exclusion pattern from my branch fixes the issue on many, but not quite all pages. The scripts for embedding video do require content from some pages that do not serve https properly, but according to my own testing, this can be circumvented, as all the actual media content is served on https. Seems impossible to fix on mixed content-skeptical platforms though. I'll try to get in touch with a dev and get back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants